Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update calc.py to support srain_piezo #202

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smuliv
Copy link

@smuliv smuliv commented Sep 28, 2024

Add support for binary sensor "Rain State Piezo" (srain_piezo)

pull request (home-assistant/core#127004) to update integration in core already made.

This PR fixes or closes issue: #200 & home-assistant/core#125850

Add support for binary sensor "Rain State Piezo" (srain_piezo)
@airhead1234
Copy link

Works for me, too. Would be great to see the component updated.

@GSzabados
Copy link

@joostlek and @pvizeli, the PR for the Ecowitt integration (home-assistant/core#127004) and this PR and its companion (#203) for aioecowitt should have ended up in the What the Heck Month... All three of them has been submitted and none of them has been reviewed, but the one for HA has been prematurely closed, as waiting for the two to be merged to aioecowitt. All of these sitting as idle ducks without any interaction, but has about 4 issues related to them. And the author mentions them every month in one of the issues. Maybe the libraries should have a notification set up for review as the components has it for HA. #whattheheckmonth

@joostlek
Copy link
Member

Yes I recently brought this up and I'm trying to get these PRs merged. Please stay tuned.

@GSzabados
Copy link

Cool! Thanks! And please excuse me for the comment above, but I don't understand why positive contributions ends up without any interaction for months.
I just updated my Ecowitt Station recently and seeing all the warnings in HA and started to research any issue. But I only see that positive contributions have been closed and neglected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants