Increase soil moisture sensor from 8 to 16 #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review and approve this so I can have the extra channels enabled |
|
@pvizeli would it be possible to quickly review this and the other PRs in this repo? They're all very small, and I believe would all result in closed bugs in HA core. Please let me know if there is anything I can do to move it along. Thank you. |
|
@pvizeli I've reviewed zacs code and it looks pretty straight forward. Is there anything stopping you from merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent Ecowitt firmware allowed hubs to receive data from 16 soil moisture sensors, instead of 8. This change just adds sensor mappings for sensors 9-16.