-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to bump Matter SDK dependency #58
Conversation
It seems Dependabot can't handle submodules with recursive submodules well: It fetches them recursively and ultimately runs out of space. See also: dependabot/dependabot-core#9376
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be actually job for the @renovatebot but this will work as well without any black box magic (which Renovate still is for me). Still see couple of remarks below.
Also, I will consider using git describe --tags
reference at least in the PR title, as it's a bit less cryptic in the commit history. It seems that the output is quite reasonable in the connectedhomeip repo.
run: | | ||
git submodule update --init connectedhomeip/ | ||
short_hash_before=$(cd connectedhomeip && git rev-parse --short HEAD) | ||
echo "short_hash_before=${short_hash_before}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use outputs
in another step within the same job even not defining jobs.<job_id>.outputs
? I can't figure it out from the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They use the same syntax to define the output of the whole job. But yeah, it seems not documented. But it works 😅
Co-authored-by: Jan Čermák <[email protected]>
It seems Dependabot can't handle submodules with recursive submodules
well: It fetches them recursively and ultimately runs out of space.
Let's use our own workflow instead.
See also: dependabot/dependabot-core#9376