Create script to generate notification enums and check if git is dirty #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
may rework this to generate it like we do for multilevel sensor constants |
marcelveldt
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
looks fine by me.
if we expect this to be ever going to change/extend, we might want to add a fallback handler to unknown ?
example: https://github.com/home-assistant-libs/aiohue/blob/master/aiohue/v2/models/feature.py#L97
raman325
changed the title
MartinHjelmare
approved these changes
Oct 5, 2023
|
this needs to be merged before we finalize the notification CC constants in this PR: zwave-js/node-zwave-js#6368 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prep for zwave-js/certification-backlog#9
EDIT: I've also added a dirty repo check at the bottom of each script. The thought is that we can set up a workflow to run those once a day via tox. That will allow us to catch if/when the constants change