Fix zwave_js set_config_parameter WS api regression #109042
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR fixes a breaking API regression of the Z-Wave JS
set_config_parameter
WS API, that was introduced in 2023.11.0 (here). Specifically this upstream PR, which was marked as a breaking change, changed the return type ofasync_set_config_parameter
, but no follow up change was made in the integration.Prior to the change, the frontend was receiving an object with a string field named
"status"
(here), with valid values"accepted"
or"queued"
. After the upstream change, an object is being returned instead of the string. This results in the configuration page showing a grey circle and no text, instead of useful icons and text.The fix is to just pass the string status result as was originally done.
Type of change
Additional information
Reported in the community forum:
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: