-
-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document system managed field for addons #2226
base: master
Are you sure you want to change the base?
Conversation
WalkthroughWalkthroughRecent updates to the Supervisor API documentation have introduced two new fields, Changes
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Additional context usedMarkdownlint
Additional comments not posted (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
aa6b651
to
90ce372
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
<ApiEndpoint path="/addons/<addon>/sys_options" method="post"> | ||
Change options specific to system managed addons. | ||
|
||
This endpoint is only callable by Home Assistant and not by any other client. | ||
|
||
**Payload** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the heading formatting.
Use a proper heading instead of emphasis for the payload section to adhere to Markdownlint rules.
- **Payload**
+ #### Payload
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
<ApiEndpoint path="/addons/<addon>/sys_options" method="post"> | |
Change options specific to system managed addons. | |
This endpoint is only callable by Home Assistant and not by any other client. | |
**Payload** | |
<ApiEndpoint path="/addons/<addon>/sys_options" method="post"> | |
Change options specific to system managed addons. | |
This endpoint is only callable by Home Assistant and not by any other client. | |
#### Payload |
Tools
Markdownlint
325-325: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
Proposed change
Document new system managed options added for addons in home-assistant/supervisor#5145
Type of change
Additional information
Summary by CodeRabbit
system_managed
andsystem_managed_config_entry
fields for add-on details.system_managed
attribute in the add-on models documentation, indicating Home Assistant management status.