Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add it's allowed for custom swing modes in ClimateEntity #2320

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add it's allowed for custom swing modes in ClimateEntity #2320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/core/entity/climate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ A device's fan can have different states. There are a couple of built-in fan mod

### Swing modes

The device fan can have different swing modes that it wants the user to know about/control.
The device fan can have different swing modes that it wants the user to know about/control. There are a couple of built-in presets that will offer translations, but you're also allowed to add custom presets.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't talk about presets since that's another feature.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not actually sure we currently allow custom swing modes, even if there are some integrations that do that now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. It should say swing and not preset.

I guess we support custom swing modes as otherwise it would have become an enum? It would appear strange if this didn't as every integration/vendor defines it very differently.
But I have no proof as it wasn't written here it was allowed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enums is newer than the climate integration. We can't go on that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant modes and actions was "converted" to enum while swing/fan/preset was not.
Anyhow there is maybe a note somewhere from some long-time-ago meeting (or should we raise a discussion to make a decision)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did scan through the architecture rep but couldn't find any old issue or discussion that would provide any guidance.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened discussion: home-assistant/architecture#1144


| Name | Description |
| ------------------ | ------------------------------------------------- |
Expand Down