-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for azure_storage #36572
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe pull request introduces a new documentation file for the Azure Storage integration in Home Assistant. The markdown file provides comprehensive details about integrating Azure Storage for backup purposes, including configuration instructions, limitations, and troubleshooting guidance. The documentation covers how users can set up Azure Storage accounts for Home Assistant backups, specifying the required parameters and authentication methods. Changes
Sequence DiagramsequenceDiagram
participant User
participant HomeAssistant
participant AzureStorage
User->>HomeAssistant: Configure Azure Storage
HomeAssistant->>AzureStorage: Authenticate with Storage Account Key
alt Authentication Successful
AzureStorage-->>HomeAssistant: Access Granted
HomeAssistant->>AzureStorage: Create/Use Backup Container
else Authentication Failed
AzureStorage-->>HomeAssistant: Access Denied
HomeAssistant->>User: Configuration Error
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (5)
source/_integrations/azure_storage.markdown (5)
15-15
: Consider expanding the introductionWhile the introduction is clear, it would be helpful to add a brief explanation of what users can do with Azure Storage backups (e.g., frequency, retention, restoration process).
19-26
: Add security recommendationsConsider adding security best practices such as:
- Recommending the use of a dedicated storage account for Home Assistant
- Using the principle of least privilege when configuring storage account permissions
- Mentioning the importance of secure storage account key handling
31-32
: Fix hyphenation and consider additional limitations
- Fix the hyphenation in "key-based authentication"
- Consider adding these common limitations:
- Maximum backup size limitations
- Network bandwidth considerations
- Pricing implications
-- Since only key based authentication is possible, this has to be enabled in your storage account. ++ Since only key-based authentication is possible, this has to be enabled in your storage account.🧰 Tools
🪛 LanguageTool
[uncategorized] ~32-~32: This expression is usually spelled with a hyphen.
Context: ...re supported at this point - Since only key based authentication is possible, this has to...(BASED_HYPHEN)
34-38
: Enhance removal instructionsConsider adding:
- What happens to existing backups when the integration is removed
- Steps to clean up Azure resources if no longer needed
- Data retention considerations
28-28
: Remove extra blank lineRemove one of the consecutive blank lines to follow markdown formatting guidelines.
🧰 Tools
🪛 Markdownlint (0.37.0)
28-28: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/azure_storage.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/azure_storage.markdown
[uncategorized] ~32-~32: This expression is usually spelled with a hyphen.
Context: ...re supported at this point - Since only key based authentication is possible, this has to...
(BASED_HYPHEN)
🪛 Markdownlint (0.37.0)
source/_integrations/azure_storage.markdown
44-44: (Shared Key
access)[https://learn.microsoft.com/en-us/azure/storage/common/shared-key-authorization-prevent?tabs=portal#remediate-authorization-via-shared-key]
Reversed link syntax
(MD011, no-reversed-links)
28-28: Expected: 1; Actual: 2
Multiple consecutive blank lines
(MD012, no-multiple-blanks)
🔇 Additional comments (1)
source/_integrations/azure_storage.markdown (1)
4-4
: Verify the release version
The release version 2025.2
seems unusually far in the future. Please verify if this is the intended version number for this integration.
{% details "Authentication failure" %} | ||
|
||
Check that your storage account allows (`Shared Key` access)[https://learn.microsoft.com/en-us/azure/storage/common/shared-key-authorization-prevent?tabs=portal#remediate-authorization-via-shared-key]. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix link syntax and expand troubleshooting scenarios
- Fix the reversed link syntax:
-(`Shared Key` access)[https://learn.microsoft.com/en-us/azure/storage/common/shared-key-authorization-prevent?tabs=portal#remediate-authorization-via-shared-key]
+[`Shared Key` access](https://learn.microsoft.com/en-us/azure/storage/common/shared-key-authorization-prevent?tabs=portal#remediate-authorization-via-shared-key)
- Consider adding these common troubleshooting scenarios:
- Network connectivity issues
- Permission-related problems
- Backup size limitations
- Common error codes and their solutions
Committable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 Markdownlint (0.37.0)
44-44: (Shared Key
access)[https://learn.microsoft.com/en-us/azure/storage/common/shared-key-authorization-prevent?tabs=portal#remediate-authorization-via-shared-key]
Reversed link syntax
(MD011, no-reversed-links)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (4)
source/_integrations/azure_storage.markdown (4)
15-15
: Enhance the introduction with more contextConsider expanding the introduction to include:
- Brief overview of backup capabilities
- Benefits of using Azure Storage for backups
- Any prerequisites or Azure-specific requirements
31-32
: Fix hyphenation and expand limitations
- Fix the hyphenation in "key-based authentication"
- Consider adding these additional limitations:
- Maximum backup size limitations
- Supported backup frequency
- Network bandwidth considerations
- Regional availability restrictions
-- Since only key based authentication is possible, this has to be enabled in your storage account. ++ Since only key-based authentication is possible, this has to be enabled in your storage account.🧰 Tools
🪛 LanguageTool
[uncategorized] ~32-~32: This expression is usually spelled with a hyphen.
Context: ...re supported at this point - Since only key based authentication is possible, this has to...(BASED_HYPHEN)
34-38
: Add data retention informationConsider adding information about:
- What happens to existing backups after removal
- Steps to manually delete backups if needed
- Data retention policies in Azure Storage
28-28
: Remove extra blank lineRemove one of the consecutive blank lines to comply with markdown formatting standards.
🧰 Tools
🪛 Markdownlint (0.37.0)
28-28: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/azure_storage.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/azure_storage.markdown
[uncategorized] ~32-~32: This expression is usually spelled with a hyphen.
Context: ...re supported at this point - Since only key based authentication is possible, this has to...
(BASED_HYPHEN)
🪛 Markdownlint (0.37.0)
source/_integrations/azure_storage.markdown
28-28: Expected: 1; Actual: 2
Multiple consecutive blank lines
(MD012, no-multiple-blanks)
🔇 Additional comments (2)
source/_integrations/azure_storage.markdown (2)
4-4
: Verify the release version
The release version is set to 2025.2
, which seems unusually far in the future. Please verify if this is the intended version or if it should be adjusted to a closer release.
40-46
: Expand troubleshooting scenarios
Add more common troubleshooting scenarios:
- Network connectivity issues
- Permission-related problems
- Backup size limitations
- Common error codes and their solutions
{% configuration_basic %} | ||
Storage account name: | ||
description: "The name of the storage account. Only the name, nothing else." | ||
Container name: | ||
description: "Blob container name to store the backups. If the container does not exist, it will be created. Defaults to `hass-backups`." | ||
Storage account key: | ||
description: "One of the two storage account keys. Used to authenticate against the storage account" | ||
{% endconfiguration_basic %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add more configuration details
Please enhance the configuration section with:
- Format requirements for the storage account name (allowed characters, length)
- Security best practices for handling the storage account key
- Container name restrictions and naming rules
- Optional configuration parameters if any
Proposed change
SSIA
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
New Features
Documentation