feat(botonic-react): Replace scroll behavior in scrollIntoView for a CSS property #2953
+4
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d add it as a CSS property in the ScrollableMessageList component
vanbasten17
approved these changes
Dec 20, 2024
Iru89
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace the
behavior: 'smooth'attribute set to thescrollIntoViewcalls for ascroll-behavior: 'smooth'CSS property set in theScrollableMessageListcomponent.This way we ensure to have the same behavior as before without affecting the main website.
Context
Under some circumstances, the
scrollIntoViewfunction with the smooth behavior was affecting the main website and the scroll was being also made there.Approach taken / Explain the design
To document / Usage example
Testing
The pull request has no tests.