-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Indy/Vdrtools #1298
Remove Indy/Vdrtools #1298
Conversation
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
…ed verkeys in legacy verkey resolution Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
Signed-off-by: gmulhearn <[email protected]>
AATH status:
|
Signed-off-by: gmulhearn <[email protected]>
FWIW: Anonyome was able to consume this update with no issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really awesome PR to see, thank you for the work that went into it!
rm mysql wallet tests for now, i don't believe these ever worked for askar, we may need to look into it if we want to support it
Seems appropriate to me--I'd leave it out until need arises or if someone volunteers to add it. If we think it's important we can create a GH issue to track it.
Closes #1250
Other changes
I believe switching the pipelines has caused a whole lot of new tests to run in askar mode, so there's plenty of new test failures.
verify
function only worked if the signer key is owned by the wallet; not useful for verify external signersunpack
alg, where the reported sender_vk was missing 1 step of base58 decoding.