Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add InferUncoerced type utility #1181

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ziad-saab
Copy link

@ziad-saab ziad-saab commented May 10, 2023

Works exactly like Infer, except where part of the schema is coerced, returns the un-coerced type instead.

Works exactly like Infer, except where part of the schema is coerced,
returns the un-coerced type instead.
@ziad-saab ziad-saab force-pushed the zs/infer-uncoerced branch from c269d43 to b10c37c Compare May 10, 2023 04:26
@ziad-saab ziad-saab marked this pull request as draft May 10, 2023 04:31
@ziad-saab ziad-saab force-pushed the zs/infer-uncoerced branch from fb847ca to f8a08fe Compare May 10, 2023 19:49
- improve `InferUncoerced`: the logic to decide what the uncoerced type
is happens in the `coerce` function instead, where it should be
- improve the uncoerced type parameter in the return type of `defaulted`
@ziad-saab ziad-saab force-pushed the zs/infer-uncoerced branch from f8a08fe to 3e9dc1a Compare May 10, 2023 19:53
@ziad-saab ziad-saab marked this pull request as ready for review May 10, 2023 19:59
@amok
Copy link

amok commented Nov 2, 2023

Any chance it gets merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants