Skip to content

Commit

Permalink
1.0.2 release
Browse files Browse the repository at this point in the history
  • Loading branch information
outdooricon committed Dec 2, 2014
1 parent b746391 commit f222639
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 7 deletions.
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,9 @@ You can add the `data-bb-options` attribute to your anchor to allow passing of t
* Open `test/test-runner.html` to run the in-browser test suite, or run `npm test` for headless.

## Change Log
### 1.0.2
* Bugfix: queryParams defined in state.url are dropped from the _urlAsTemplate

### 1.0.1
* Bugfix: queryParams are getting dropped when transition navigate occurs

Expand Down
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "Backbone.Manager",
"version": "1.0.1",
"version": "1.0.2",
"homepage": "https://github.com/novu/Backbone.Manager",
"author": "Johnathon Sanders",
"description": "State-Based Routing/Control Manager for Backbone",
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "Backbone.Manager",
"version": "1.0.1",
"version": "1.0.2",
"description": "State-Based Routing/Control Manager for Backbone",
"homepage": "https://github.com/novu/backbone.manager",
"bugs": "https://github.com/novu/backbone.manager/issues",
Expand Down
2 changes: 1 addition & 1 deletion release/backbone.manager-min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion release/backbone.manager-min.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 8 additions & 3 deletions release/backbone.manager.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
* Backbone.Manager - State-Based Routing/Control Manager for Backbone
* @version v1.0.1
* @version v1.0.2
* @link https://github.com/novu/backbone.manager
* @author Johnathon Sanders
* @license MIT
Expand All @@ -10,7 +10,7 @@
managers = [];
managerQueue = _.extend({}, Backbone.Events);
onloadUrl = window.location.href;
cachedParamMatcher = /[:*]([^(:)/]+)/g;
cachedParamMatcher = /[:*]([^(:?)/]+)/g;
cachedOptionalMatcher = /\(.*\)/g;
currentManager = null;
Manager = (function() {
Expand Down Expand Up @@ -108,7 +108,12 @@
queryParams = _.last(params);
url = stateOptions._urlAsTemplate(paramsObject);
if (queryParams) {
url += '?' + queryParams;
if (url.indexOf('?') > -1) {
url += '&';
} else {
url += '?';
}
url += queryParams;
}
if (!historyHasUpdated && transitionOptions.navigate) {
this.router.navigate(url);
Expand Down

0 comments on commit f222639

Please sign in to comment.