Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QOL change: Export Model class #354

Merged
merged 2 commits into from
Oct 22, 2023
Merged

QOL change: Export Model class #354

merged 2 commits into from
Oct 22, 2023

Conversation

bbroere
Copy link

@bbroere bbroere commented Oct 16, 2023

We have a formula input in a separate component in which we want to use the data from the spreadsheet as our model.
The problem we have is that the data is, logically, not evaluated and it will still contain formulas, resulting to a formula string instead of an evaluated number.
If we want to evaluate the formula outside of the data, we need to use the Model class.
This class already has the dependency graph and the evaluation of the data, so that should be it

Local tests show that this change is enough to allow external formulas to be evaluated over the data, even nested formulas (e.g. External: '=A1+A2', A1: '=2+3', A2: '=2*A1' results in 15)
It would be great if the Model is exported from the root index.ts, hence this PR.

@iddan
Copy link
Owner

iddan commented Oct 21, 2023

Please fix CI issues

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6601776142

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.496%

Totals Coverage Status
Change from base Build 6362464575: 0.0%
Covered Lines: 1127
Relevant Lines: 1300

💛 - Coveralls

@iddan iddan merged commit 2d4861a into iddan:master Oct 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants