add test to display foveated areas #201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toji
approved these changes
Nov 13, 2024
| @@ -0,0 +1,553 @@ | |||
| <!doctype html> | |||
| <!-- | |||
| Copyright 2018 The Immersive Web Community Group | |||
There was a problem hiding this comment.
Suggested change
| Copyright 2018 The Immersive Web Community Group | |
| Copyright 2024 The Immersive Web Community Group |
| } | ||
| } | ||
|
|
||
| function createScene(gl) |
There was a problem hiding this comment.
As this is a test page and not a "sample" I'm not too concerned about it, but this is pretty different from the structure of most of our pages. From the looks of the comments it seems like it's ported from some Meta sample code? If it's publicly accessible code it would be good to add a comment somewhere indicating what this code is based on with a URL where the original can be found.
| for ( var i = 0; i < NUM_INSTANCES; i++ ) | ||
| { | ||
| obj.CubePositions[i] = { x:0, y:0, z:0 }; | ||
| // Using volatile keeps the compiler from optimizing away multiple calls to ovrScene_RandomFloat(). |
There was a problem hiding this comment.
It would be worth doing a pass over the comments to make sure they still make sense in this context. volatile isn't a concept that your average JavaScript developer knows about (or wants to know about, for that matter...😁)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test that shows the areas and strength of the foveated areas in an XR scene