refactor(server): use includeNull in query for search suggestions
#14626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldietzler
approved these changes
Dec 10, 2024
|
I think the e2e only worked because there were assets without entries in the exif table at the time of the test. The inner join would mean null isn't one of the options in that case. Since the inner join is good to have regardless, I changed it to just add |
yosit
pushed a commit
to yosit/immich
that referenced
this pull request
Dec 20, 2024
…mmich-app#14626) * use `includeNull` * push down `includeNull` into query, inner joins * remove filter * update sql * fix tests * maybe fix e2e * more e2e tests * handle no exif row * whoops * update sql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracted out from the Kysely branch, this PR refactors the search suggestion methods to use the
includeNulloption and empty string filter into the queries themselves and changes the queries to use inner joins.