feat(server): add Bash healthcheck script #14704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldietzler
approved these changes
Dec 15, 2024
bo0tzz
previously requested changes
Dec 15, 2024
I can delete the node script if there won't be any need for it. I should've done that eariler but I forgot to |
mmomjian
reviewed
Dec 16, 2024
…into bash-healthcheck
mmomjian
reviewed
Dec 16, 2024
| if [ "$result" != "{\"res\":\"pong\"}" ]; then | ||
| echo "Fail: didn't reply with pong"; | ||
| exit 1; | ||
| fi |
There was a problem hiding this comment.
I would explicitly exit 0 at the end of the script. Otherwise looks good to me. Ty!
|
Hmm, I was wondering why disk is so often queried... Is it possible to disable health check or make it not access storage so that HDDs can spin down? |
yosit
pushed a commit
to yosit/immich
that referenced
this pull request
Dec 20, 2024
* feat(server): add Bash healthcheck script * fix(server): add 2 second timeout for healthcheck.js parity * chore(server): delete old healthcheck Node script * fix(server): feedback --------- Co-authored-by: Alex <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current health check script starts up a Node JS script every time it's called. This becomes an issue in low-powered devices hosting Immich as the startup process can be CPU-intensive. The CPU usage bursts can compromise overall system stability.
#10312 (Orange Pi 5+) and #14364 (Raspberry Pi 4) are examples of users of such devices complaining about the usage spikes, where the only solution was to disable health checking entirely.
In testing with an old desktop PC (Intel Pentium E5400, 2GB of RAM + 4GB of ZRAM), replacing the JS healthcheck with a Bash one eliminated the spikes.
I have tried to replicate the behavior of the original healthcheck script as closely as I could, including an early exit when the
apiworker is excluded or left out of IMMICH_WORKERS_INCLUDE. I also passed it through Shellcheck to prevent bugs.