Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): fix missing icons #14737

Merged
merged 5 commits into from
Dec 17, 2024
Merged

Conversation

aviv926
Copy link
Contributor

@aviv926 aviv926 commented Dec 17, 2024

Fixes #14702

Before:

Before.mp4

After:

After.mp4

@aviv926 aviv926 changed the title fix(web):fix missing icons fix(web): fix missing icons Dec 17, 2024
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this improves on the current state, but ideally the overflowed icons go into the overflow menu 😆

@jrasm91 jrasm91 merged commit 2948b9e into immich-app:main Dec 17, 2024
33 checks passed
@ajpanton
Copy link
Contributor

ajpanton commented Dec 17, 2024

I guess this improves on the current state, but ideally the overflowed icons go into the overflow menu 😆

Yeah the scrolling ability isn't very visible, and I would personally never guess it's scrollable and would create the same bug report again if I hadn't already and didn't read this.

I would propose one of three options:

  1. Replace the left-most icon with something that shows that there are more icons. Not really sure what this would look like. A horizontal three dots would've been good, if it was actually the left-most icon, but it's not, as there's the "back" arrow. Maybe a fade-out on the left-most icon? A different-looking left-arrow?
  2. Add a bar under the icons showing the horizontal scroll position, making it obvious that you're currently all the way to the right and there might be something more to the left.
  3. Put the additional icons in the overflow menu.

@aviv926 aviv926 deleted the fix-Icons-missing branch December 17, 2024 19:09
@jrasm91
Copy link
Contributor

jrasm91 commented Dec 17, 2024

(3) is the only viable solution IMO.

yosit pushed a commit to yosit/immich that referenced this pull request Dec 20, 2024
* Updates

* fix

* Revert "Updates"

This reverts commit 724b538.

* format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icons missing from photo toolbar when screen too narrow (web)
3 participants