feat: Mark people as favorite #14866
Conversation
…he front of the people list
| if (person.id === updatedPerson.id) { | ||
| return updatedPerson; | ||
| } | ||
| return person; |
There was a problem hiding this comment.
When can you possibly not find your person in here?
There was a problem hiding this comment.
Not exactly sure what you mean, this is inside of the map, its replacing the updatedPerson inside of the person list.
And I just copied the code for the other handlers in that file :D
There was a problem hiding this comment.
What I had in mind is that const index = findIndex((person) => person.id === detail.id) followed by people[index] = updatedPerson should also work and is imo more intuitive to read. (plus it should be a touch more efficient lol)
There was a problem hiding this comment.
Ahh right, I refactored it like that now 👍
|
I added a simple unit test for testing the toggling, I also tried adding a test to check the sorting behaviour, tho I have not ran it locally and it was mostly guessing that this could work :D @danieldietzler |
Added the ability to mark people as favorite on web.
The
GET /peopleEndpoint then sorts favorited people to the front of the list.Thus the sorting would also apply in the app, however I have not (yet) added any indicators or functionality to mark people as favorite from there.