-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): Enable selection interactions in folder view #15049
feat(web): Enable selection interactions in folder view #15049
Conversation
const triggerAssetUpdate = () => {}; | ||
|
||
const onAddToAlbum = (assetIds: string[]) => { | ||
// if (terms.isNotInAlbum.toString() == 'true') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we handle this case as well?
}; | ||
|
||
const onAssetDelete = (assetIds: string[]) => { | ||
// const assetIdSet = new Set(assetIds); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we handle this case as well?
I implemented the refreshing of assets @alextran1502 I also added a button in the Asset View Detail Pane that links to the containing folder. That way, when you open an asset from the timeline or search, you can jump straight into the folder view to the correct folder. This button only shows up, if folders are enabled and the Folder sidebar link is also activated. |
Hi @arnolicious, I just tested the PR, and it works well. For navigating to the folder from the detail panel, can we make this link clickable instead? |
@@ -31,6 +31,9 @@ | |||
mdiClose, | |||
mdiEye, | |||
mdiEyeOff, | |||
mdiFolder, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the unused code so the tests pass, thank you
So I don't know if this was intentionally omitted, or just wasn't implemented yet.
I hope it's the latter, since I would find this very useful, aswell as a few other people in #14307
I haven't been able to test it completely, since I'm on windows and my bind mounts seem to be a lil fucked up, resulting in folders with only one image in it, so some other testers would be greatly appreciated.
If this was indeed intentionally omitted, feel free to close the PR
Edit
I also added a button in the Asset View Detail Pane that links to the containing folder. That way, when you open an asset from the timeline or search, you can jump straight into the folder view to the correct folder.
This button only shows up, if folders are enabled and the Folder sidebar link is also activated.
Closes #14307