Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): option to decide, if HDR videos should be transcoded #15122

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Hely0n
Copy link
Contributor

@Hely0n Hely0n commented Jan 6, 2025

This will implement this Feature Request:
#12844

I still have to create Unit Tests and go through the PR checklist (lint, test, prettier, ...)

@Hely0n Hely0n requested a review from danieldietzler as a code owner January 6, 2025 21:03
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Label error. Requires exactly 1 of: changelog:.*. Found: documentation, 🖥️web, 🗄️server. A maintainer will add the required label.

@github-actions github-actions bot added documentation Improvements or additions to documentation 🖥️web 🗄️server labels Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

📖 Documentation deployed to pr-15122.preview.immich.app

@Hely0n Hely0n marked this pull request as draft January 7, 2025 02:30
@Hely0n
Copy link
Contributor Author

Hely0n commented Jan 7, 2025

@mertalev I have changed the unit tests a little bit, but I think you should decide, how to change them 😅.
The failing tests are about HW accel, which unfortunately is out of my competences.

Just let me now, if you want me to add something

@Hely0n Hely0n changed the title Option to decide, if HDR videos should be transcoded feat(server): option to decide, if HDR videos should be transcoded Jan 7, 2025
@Hely0n
Copy link
Contributor Author

Hely0n commented Jan 7, 2025

There seems to be a problem with the the web tests. It says the attribute is not present in SystemConfigFfmpegDto, but I have added it there.

I think it's something with open-api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation 🗄️server 🖥️web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant