[Fix] no-duplicates with type imports #2716

snewcomer · 2023-02-12T19:38:25Z

Follow up fixes to #2475

Ref bug PRs:

ljharb

and so on, all the loops should be iteration methods whenever possible :-)

src/rules/no-duplicates.js

simmo · 2023-02-14T12:47:49Z

Am I correct this would fix #2675 ? If so this is my new favourite PR. 😄

If you need any testing done, I can probably help.

runspired · 2023-02-14T20:21:23Z

all the loops should be iteration methods whenever possible

Is there a reason for this guidance?

ljharb · 2023-02-14T21:53:38Z

@runspired loops make code harder to understand and reason about. It's explained in the airbnb styleguide as well.

ljharb

Look forward to the other 2 fixes :-)

src/rules/no-duplicates.js

mrm007 · 2023-04-08T05:54:03Z

Look forward to the other 2 fixes :-)

@ljharb @snewcomer I am very interested in these fixes, so I wanted to take a stab at the remaining TODO items. As it turns out, they were already covered by this PR!

I reorganised some tests (inspired by tests/src/rules/consistent-type-specifier-style.js) to prove that both TypeScript and Flow work — see snewcomer#1

Test results

no-duplicates

<snip>

with types
  Babel/Flow
    no-duplicates
      valid
        ✓ import type { x } from './foo'; import y from './foo'
        ✓ import type x from './foo'; import type y from './bar'
        ✓ import type {x} from './foo'; import type {y} from './bar'
        ✓ import type x from './foo'; import type {y} from './foo'
        ✓ 
      import type {} from './module';
      import {} from './module2';
    
        ✓ 
      import type { Identifier } from 'module';

      declare module 'module2' {
        import type { Identifier } from 'module';
      }

      declare module 'module3' {
        import type { Identifier } from 'module';
      }
    
        ✓ import { type x } from './foo'; import type y from 'foo'
      invalid
        ✓ import { type x } from './foo'; import y from './foo';
        ✓ import type x from './foo'; import type y from './foo'
        ✓ import type x from './foo'; import type x from './foo'
        ✓ import type {x} from './foo'; import type {y} from './foo'
        ✓ import {type x} from './foo'; import {y} from './foo'
        ✓ import type {x} from './foo'; import {type y} from './foo'
        ✓ import type {x} from './foo';import {type y} from './foo';
        ✓ import {type x} from './foo'; import type {y} from './foo';
        ✓ import {type x} from 'foo'; import type {y} from 'foo'
        ✓ import {type x, C} from './foo'; import type {y} from './foo';
        ✓ import type {y} from './foo'; import {type x, C} from './foo';
        ✓ import {type x, C} from 'foo';import type {y} from 'foo';
        ✓ import type {y} from './foo'; import {type x, C} from './foo';
        ✓ import {type x} from './foo';import {type y} from './foo';
        ✓ import {type x} from './foo';import {type y} from './foo';
        ✓ import {type x} from './foo';import {type y} from './foo';import {type z} from './foo';
        ✓ import {type x} from './foo';import {type y} from './foo';import A from './foo';
        ✓ import {type x} from './foo';import {type y} from './foo';import A, { C } from './foo';
        ✓ import {AValue, type x, BValue} from './foo';import {type y, CValue} from './foo';
        ✓ import AValue from './foo'; import {type y} from './foo';
        ✓ import {type y} from './foo';import AValue from './foo';
        ✓ import AValue, {BValue} from './foo'; import {type y, CValue} from './foo';
        ✓ import {AValue, type x, BValue} from './foo'; import type {y} from './foo';
        ✓ import {AValue, type x, BValue} from './foo'; import type {y} from './foo'
        ✓ import AValue, {type x, BValue} from './foo';import type {y} from './foo';
        ✓ import AValue, {type x, BValue} from './foo'; import type {y} from './foo'
        ✓ import { type C, } from './foo';import {AValue, BValue, } from './foo';
  TypeScript
    no-duplicates
      valid
        ✓ import type { x } from './foo'; import y from './foo'
        ✓ import type x from './foo'; import type y from './bar'
        ✓ import type {x} from './foo'; import type {y} from './bar'
        ✓ import type x from './foo'; import type {y} from './foo'
        ✓ 
      import type {} from './module';
      import {} from './module2';
    
        ✓ 
      import type { Identifier } from 'module';

      declare module 'module2' {
        import type { Identifier } from 'module';
      }

      declare module 'module3' {
        import type { Identifier } from 'module';
      }
    
        ✓ import { type x } from './foo'; import type y from 'foo'
      invalid
        ✓ import { type x } from './foo'; import y from './foo';
        ✓ import type x from './foo'; import type y from './foo'
        ✓ import type x from './foo'; import type x from './foo'
        ✓ import type {x} from './foo'; import type {y} from './foo'
        ✓ import {type x} from './foo'; import {y} from './foo'
        ✓ import type {x} from './foo'; import {type y} from './foo'
        ✓ import type {x} from './foo';import {type y} from './foo';
        ✓ import {type x} from './foo'; import type {y} from './foo';
        ✓ import {type x} from 'foo'; import type {y} from 'foo'
        ✓ import {type x, C} from './foo'; import type {y} from './foo';
        ✓ import type {y} from './foo'; import {type x, C} from './foo';
        ✓ import {type x, C} from 'foo';import type {y} from 'foo';
        ✓ import type {y} from './foo'; import {type x, C} from './foo';
        ✓ import {type x} from './foo';import {type y} from './foo';
        ✓ import {type x} from './foo';import {type y} from './foo';
        ✓ import {type x} from './foo';import {type y} from './foo';import {type z} from './foo';
        ✓ import {type x} from './foo';import {type y} from './foo';import A from './foo';
        ✓ import {type x} from './foo';import {type y} from './foo';import A, { C } from './foo';
        ✓ import {AValue, type x, BValue} from './foo';import {type y, CValue} from './foo';
        ✓ import AValue from './foo'; import {type y} from './foo';
        ✓ import {type y} from './foo';import AValue from './foo';
        ✓ import AValue, {BValue} from './foo'; import {type y, CValue} from './foo';
        ✓ import {AValue, type x, BValue} from './foo'; import type {y} from './foo';
        ✓ import {AValue, type x, BValue} from './foo'; import type {y} from './foo'
        ✓ import AValue, {type x, BValue} from './foo';import type {y} from './foo';
        ✓ import AValue, {type x, BValue} from './foo'; import type {y} from './foo'
        ✓ import { type C, } from './foo';import {AValue, BValue, } from './foo';


123 passing (560ms)

niklasnatter · 2023-04-11T08:10:20Z

Hey, it would be great to handle type imports with no-duplicates - Is there anything that I could help with?

mrm007 · 2023-05-23T23:51:14Z

Is there anything else we can help with to get this merged? It's a great improvement over the current behaviour.

seanCodes · 2023-06-29T03:19:28Z

Also eager to see this merged and happy to help where needed!

oceandrama · 2023-07-14T09:33:27Z

@snewcomer Hi! Sorry for mention, but this PR is super helpfull and it will be great to see this merged! Are there any additional things you would like to work on?
Maybe it also fixes #2792

niklasnatter · 2023-07-27T08:29:24Z

I havent tested yet, but this might be fixed by #2835

ljharb · 2023-07-27T20:44:30Z

I've rebased this PR, but tests seem to be failing. @mrm007 sorry i hadn't looked at your PR-PR yet - would you mind rebasing yours, and then I can pull it in?

ljharb · 2023-07-28T17:40:45Z

@snewcomer is there a reason you overwrote my rebase?

Co-authored-by: Jordan Harband <[email protected]>

snewcomer · 2023-08-06T19:40:25Z

Hi sorry. I didn't see any commits. If I was mistaken due to keeping this PR open in Safari and not getting real time updates, I'm sorry.

FYI put a comment here.

f302f7d#r123760801

snewcomer force-pushed the sn/fix-no-duplicates branch 2 times, most recently from ab7a2d8 to d2292bb Compare February 12, 2023 20:13

ljharb reviewed Feb 13, 2023

View reviewed changes

snewcomer force-pushed the sn/fix-no-duplicates branch from 3025495 to 9abf816 Compare February 19, 2023 21:56

This was referenced Feb 20, 2023

[import/no-duplicates] {"prefer-inline": true} does not work #2715

Open

typescript: inline types emberjs/ember.js#20378

Draft

ljharb reviewed Feb 20, 2023

View reviewed changes

src/rules/no-duplicates.js Outdated Show resolved Hide resolved

src/rules/no-duplicates.js Outdated Show resolved Hide resolved

mrm007 mentioned this pull request Apr 8, 2023

Reorganize tests snewcomer/eslint-plugin-import#1

Open

snewcomer force-pushed the sn/fix-no-duplicates branch from a987e22 to bfdb9d0 Compare July 28, 2023 15:09

snewcomer and others added 10 commits August 6, 2023 13:42

[Fix]: no-duplicates with type imports

3e73216

Update src/rules/no-duplicates.js

5592e87

Co-authored-by: Jordan Harband <[email protected]>

Update src/rules/no-duplicates.js

eadc552

Co-authored-by: Jordan Harband <[email protected]>

Update src/rules/no-duplicates.js

8a8655b

Co-authored-by: Jordan Harband <[email protected]>

Update src/rules/no-duplicates.js

965a6ba

Co-authored-by: Jordan Harband <[email protected]>

Update src/rules/no-duplicates.js

b7b9a56

Co-authored-by: Jordan Harband <[email protected]>

one bugfix with trailing commas

085adc8

try this way instead

59e4332

moar feedback

0d2b737

comment out for now

864effb

snewcomer force-pushed the sn/fix-no-duplicates branch from bfdb9d0 to 864effb Compare August 6, 2023 18:42

askoufis mentioned this pull request Aug 16, 2023

Error for import type, Imported multiple times in typescript #2843

Closed

latin-1 mentioned this pull request Jun 2, 2024

Rule proposal: Consider bringing back no-duplicate-imports typescript-eslint/typescript-eslint#9212

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fix] no-duplicates with type imports #2716

[Fix] no-duplicates with type imports #2716

snewcomer commented Feb 12, 2023 •

edited

Loading

ljharb left a comment

simmo commented Feb 14, 2023

runspired commented Feb 14, 2023

ljharb commented Feb 14, 2023

ljharb left a comment

mrm007 commented Apr 8, 2023

niklasnatter commented Apr 11, 2023

mrm007 commented May 23, 2023

seanCodes commented Jun 29, 2023

oceandrama commented Jul 14, 2023 •

edited

Loading

niklasnatter commented Jul 27, 2023

ljharb commented Jul 27, 2023

ljharb commented Jul 28, 2023

snewcomer commented Aug 6, 2023

[Fix] no-duplicates with type imports #2716

Are you sure you want to change the base?

[Fix] no-duplicates with type imports #2716

Conversation

snewcomer commented Feb 12, 2023 • edited Loading

ljharb left a comment

Choose a reason for hiding this comment

simmo commented Feb 14, 2023

runspired commented Feb 14, 2023

ljharb commented Feb 14, 2023

ljharb left a comment

Choose a reason for hiding this comment

mrm007 commented Apr 8, 2023

niklasnatter commented Apr 11, 2023

mrm007 commented May 23, 2023

seanCodes commented Jun 29, 2023

oceandrama commented Jul 14, 2023 • edited Loading

niklasnatter commented Jul 27, 2023

ljharb commented Jul 27, 2023

ljharb commented Jul 28, 2023

snewcomer commented Aug 6, 2023

snewcomer commented Feb 12, 2023 •

edited

Loading

oceandrama commented Jul 14, 2023 •

edited

Loading