Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add start delay #78

Merged
merged 6 commits into from
Mar 26, 2024
Merged

add start delay #78

merged 6 commits into from
Mar 26, 2024

Conversation

duoertai
Copy link
Collaborator

No description provided.

@duoertai duoertai requested a review from longquanzheng March 25, 2024 11:04
@duoertai
Copy link
Collaborator Author

failed an integration test:
Error Trace: /home/runner/work/iwf-golang-sdk/iwf-golang-sdk/integ/workflow_uncompleted_test.go:116
Error: Not equal:
expected: "workflow is not completed successfully, closedStatus: FAILED, failedErrorType(applies if failed as closedStatus):STATE_API_FAIL_MAX_OUT_RETRY_ERROR_TYPE, error message:activity error (type: StateApiWaitUntil, scheduledEventID: 9, startedEventID: 10, identity: ): activity StartToClose timeout (type: StartToClose)"
actual : "workflow is not completed successfully, closedStatus: FAILED, failedErrorType(applies if failed as closedStatus):STATE_API_FAIL_MAX_OUT_RETRY_ERROR_TYPE, error message:activity error (type: StateApiWaitUntil, scheduledEventID: 8, startedEventID: 9, identity: ): activity StartToClose timeout (type: StartToClose)"

but seems not related to this change, because I also tried checking out previous commit without any of this change, and it still fails. I think it's probably some change of temporal

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.15%. Comparing base (424afc8) to head (58df29f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   69.11%   69.15%   +0.03%     
==========================================
  Files          28       28              
  Lines        1551     1553       +2     
==========================================
+ Hits         1072     1074       +2     
  Misses        390      390              
  Partials       89       89              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@duoertai duoertai enabled auto-merge (squash) March 26, 2024 10:38
@duoertai duoertai merged commit 3effa87 into indeedeng:main Mar 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants