printCommands in interface GluegunPrint is missing the optional param…

[amartincastro]

…ater #584

[kaihaase]

@amartincastro I'm sorry, it's my fault.

Either the class Toolbox has to be imported: import { Toolbox } from '../domain/toolbox' or use the interface GluegunToolbox instead of the class Toolbox:

export interface GluegunPrint {
    ...
    printCommands(toolbox: GluegunToolbox, commandRoot?: string[]): void
    ...
}

More correct would probably be to import Toolbox, since the class is also used in print-tools.ts.

[jamonholmgren]

@amartincastro Would you mind updating this PR? 🙏 Thank you!

[amartincastro]

@amartincastro Would you mind updating this PR? 🙏 Thank you!

Hey, happy to try to help but it's been about 3 months since I looked at this, and it was literally my very first OSS contribution ever, so I am a little lost for what to do next.

My original branch is 2 commits ahead of, and 91 commits behind. Should I fork off a new version of the latest Gluegun repo and make the changes, or update the branch I originally made the PR in, then make the changes? Or something else?

[amartincastro]

@amartincastro Would you mind updating this PR? 🙏 Thank you!

Hey, happy to try to help but it's been about 3 months since I looked at this, and it was literally my very first OSS contribution ever, so I am a little lost for what to do next.

My original branch is 2 commits ahead of, and 91 commits behind. Should I fork off a new version of the latest Gluegun repo and make the changes, or update the branch I originally made the PR in, then make the changes? Or something else?

I am doing Stack Overflow research to try to figure this out, but I am getting stuck on the Git workflow before even getting to the Gluegun work.

I followed the commands here to try to get my local version of the repo up-to-date so I can make the changes that @kaihaase requested on an updated version of gluegun: https://stackoverflow.com/a/7244456/6321654

But when I did, it says that Everything is up-to-date.

I am not sure where to go next. The only thing I can think of doing is to just delete my fork, refork Gluegun, make changes as requested in this issue, and make a new PR. But I feel like there's got to be a better way. I'll wait to see what you guys say before doing that.

[amartincastro]

@amartincastro Would you mind updating this PR? 🙏 Thank you!

Hey, happy to try to help but it's been about 3 months since I looked at this, and it was literally my very first OSS contribution ever, so I am a little lost for what to do next.
My original branch is 2 commits ahead of, and 91 commits behind. Should I fork off a new version of the latest Gluegun repo and make the changes, or update the branch I originally made the PR in, then make the changes? Or something else?

I am doing Stack Overflow research to try to figure this out, but I am getting stuck on the Git workflow before even getting to the Gluegun work.

I followed the commands here to try to get my local version of the repo up-to-date so I can make the changes that @kaihaase requested on an updated version of gluegun: https://stackoverflow.com/a/7244456/6321654

But when I did, it says that Everything is up-to-date.

I am not sure where to go next. The only thing I can think of doing is to just delete my fork, refork Gluegun, make changes as requested in this issue, and make a new PR. But I feel like there's got to be a better way. I'll wait to see what you guys say before doing that.

Okay, making small strides. If you look at the screenshot, I was trying to set my own repo as the upstream, and that's why it was saying it's up-to-date. When I switched the upstream it to the infinitered/gluegun, it seemed to have updated to the latest code.

I added the import to the file, saved and did a "git push". When I pushed, it seems to have just updated the PR by itself. I am not sure what's next. Github really is challenging to understand for a newcomer.

[jamonholmgren]

@amartincastro Would you want to pair on fixing this sometime?

[amartincastro]

@amartincastro Would you want to pair on fixing this sometime?

That sounds good. Are you available at some point tomorrow (Fri) morning? I am wide open with the exception of 9-9:30am PT.

[jamonholmgren]

@amartincastro How about Tuesday (May 5) at 10AM Pacific?

[amartincastro]

Works for me. How do you prefer to screenshare?

[jamonholmgren]

DM me on twitter: https://twitter.com/jamonholmgren @amartincastro

[infinitered-circleci]

🎉 This PR is included in version 4.3.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀