[v10] Fix expo template with RN upgrade #2745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix expo/expo#31005
Without this patch, the JS bundle fails to load with: ``` iOS Bundling failed 3255ms node_modules/expo/AppEntry.js (1892 modules) Unable to resolve "react-native/Libraries/Utilities/DevLoadingView" from "node_modules/@expo/metro-runtime/build/LoadingView.native.js" ``` This is in a conditional in LoadingView.native.js that should load the correct one, and does, so this appears to be an issue with conditional requires. I'm not sure how to fix that underlying issue just yet, so patching for now.
|
Follow-up issue here: #2746 |
lindboe
requested review from
frankcalise and
fpena
and removed request for
frankcalise
4 tasks
fpena
approved these changes
Aug 14, 2024
frankcalise
approved these changes
Aug 14, 2024
|
🎉 This PR is included in version 10.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn testjest tests pass with new tests, if relevantyarn linteslint checks pass with new code, if relevantyarn format:checkprettier checks pass with new code, if relevantREADME.md(or relevant documentation) has been updated with your changesDescribe your PR
Updates the RN version in use to fix an issue that was preventing all Android builds: expo/expo#31005.
Once I upgraded, though, I ran into another issue: the JS bundle fails to load with:
This is in a conditional in LoadingView.native.js that should load the correct one, and does, so this appears to be an issue with conditional requires. I'm not sure how to fix that underlying issue just yet, so patching for now.
Will file a ticket to follow up with better long-term fixes, including potentially pinning the template version in use.