fix: move to fetch_update from fetch_add for IDs #25663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change we now provide a check for new IDs for overflow. This will cause the system to panic on overflow now rather than causing silent corruption as this is an unrecoverable state. While this is a highly unlikely scenario given how big the id numbers can be, it would be better to have this in place now, rather than trying to figure out a subtle nasty corruption bug later. Closes #25542
mgattozzi
requested review from
pauldix,
hiltontj,
jacksonrnewhouse and
praveen-influx
hiltontj
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we now provide a check for new IDs for overflow. This will cause the system to panic on overflow now rather than causing silent corruption as this is an unrecoverable state. While this is a highly unlikely scenario given how big the id numbers can be, it would be better to have this in place now, rather than trying to figure out a subtle nasty corruption bug later.
Closes #25542