feat: track lines rejected in prometheus metrics #25722
Merged
+75
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the metric `influxdb3_write_lines_rejected` metric which tracks the total number of lines rejected from incoming writes. Note, that this only tacks the number of rejected lines when the default `accept_partial` of `true` is provided to incoming write requests.
|
We could also probably track rejected lines in requests that are made with |
pauldix
approved these changes
Dec 29, 2024
| @@ -4,37 +4,51 @@ use metric::{Metric, Registry, U64Counter}; | |||
|
|
|||
| #[derive(Debug)] | |||
| pub(super) struct WriteMetrics { | |||
| write_lines_total: Metric<U64Counter>, | |||
| write_bytes_total: Metric<U64Counter>, | |||
| write_lines_count: Metric<U64Counter>, | |||
There was a problem hiding this comment.
write_lines_total is the more standard naming convention. Metric names should end in units, e.g. _seconds, _bytes, or _total for unit-less metrics. See https://prometheus.io/docs/practices/naming/
There was a problem hiding this comment.
Addressed this in cd51bc2
| pub(super) const WRITE_LINES_TOTAL_NAME: &str = "influxdb3_write_lines_total"; | ||
| pub(super) const WRITE_BYTES_TOTAL_NAME: &str = "influxdb3_write_bytes_total"; | ||
| pub(super) const WRITE_LINES_METRIC_NAME: &str = "influxdb3_write_lines"; | ||
| pub(super) const WRITE_LINES_REJECTED_METRIC_NAME: &str = "influxdb3_write_lines_rejected"; |
There was a problem hiding this comment.
I mentioned this in the PR description, but our Prometheus exporter adds a "_total" to the end of metric names that use a counter on export, which is why I removed it from the names here.
There was a problem hiding this comment.
Oh sorry, I should have read that closer!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the metric
influxdb3_write_lines_rejected_totalmetric which tracks the total number of lines rejected from incoming writes.Note, that this only tacks the number of rejected lines when the default
accept_partialoftrueis provided to incoming write requests.This also changes the names of the
influxdb3_write_lines_totalandinfluxdb3_write_bytes_totalinternally toinfluxdb3_write_linesandinfluxdb3_write_bytes, respectively. Since the Prometheus exporter adds the_totalfor counter metrics for us see here, these were previously being exported asinfluxdb3_write_lines_total_totalandinfluxdb3_write_bytes_total_total- FYI @saraghds.Closes #25696