Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the tuple unpacking code #1210

Merged
merged 4 commits into from
Oct 10, 2023
Merged

remove the tuple unpacking code #1210

merged 4 commits into from
Oct 10, 2023

Conversation

konnov
Copy link
Contributor

@konnov konnov commented Oct 9, 2023

This is a follow-up to #1202. Since tuples are rewritten by the parser now, there is no need for special treatment in the simulator. This has also unblocked the old code in the tutorial 3.

@konnov konnov marked this pull request as ready for review October 9, 2023 16:39
@konnov konnov requested review from shonfeder, thpani and bugarela and removed request for shonfeder October 9, 2023 16:39
Copy link
Contributor

@thpani thpani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, I thought I'd found all the unpacking code 😂
Good that you looked it over, thanks for the cleanup!

doc/lang.md Outdated Show resolved Hide resolved
Co-authored-by: Thomas Pani <[email protected]>
@konnov konnov enabled auto-merge (squash) October 10, 2023 09:17
@konnov konnov merged commit 56d2a3c into main Oct 10, 2023
15 checks passed
@konnov konnov deleted the igor/apres-tuple-unpacking branch October 10, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants