feat(magnifying glass): use the magnifying glass to find the first choice to see on the map #1600

MSPKarengeo · 2024-01-24T22:33:08Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines:https://github.com/infra-geo-ouverte/igo2/blob/master/.github/CONTRIBUTING.md#git-commit-guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

What is the current behavior? (You can also link to an open issue here)
N/A

What is the new behavior?
The magnifying glass will find the first score that best matches the search to view it on the map

Does this PR introduce a breaking change? (check one with "x")

Yes
No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:
N/A

Other information:

alecarn · 2024-02-05T21:35:31Z

Pourrais-tu nous indiquer comment qu'on peut tester les changements?

R: Pour faire marcher la loupe, il faut activer à true dans ces deux lignes du fichier search-bar.component.ts :
https://vscode.dev/github/infra-geo-ouverte/igo2-lib/blob/nv_search_first_element_by_magnifying_glass/packages/geo/src/lib/search/search-bar/search-bar.component.ts#L288

this.showSearchButton = configValue !== undefined ? configValue : false; à true

https://vscode.dev/github/infra-geo-ouverte/igo2-lib/blob/nv_search_first_element_by_magnifying_glass/packages/geo/src/lib/search/search-bar/search-bar.component.ts#L88
public showSearchButton: boolean = false; à true

packages/geo/src/lib/search/search-bar/search-bar.component.html

packages/geo/src/lib/search/search-bar/search-bar.component.ts

packages/geo/src/lib/search/search-results/search-results.component.ts

projects/demo/src/app/geo/search/search.module.ts

packages/geo/src/locale/en.geo.json

packages/geo/src/lib/search/search-bar/search-bar.component.ts

packages/geo/src/lib/search/search-results/search-results-add-button.component.ts

packages/geo/src/lib/search/search-bar/search-bar.component.ts

MSPKarengeo · 2024-02-20T21:13:33Z

Corrections et modifications on été effectuées. Disponibles pour révision.

alecarn

Deux questionnements sinon ça me semble beau 👍

packages/geo/src/lib/search/search-bar/search-bar.component.ts

alecarn · 2024-03-11T20:00:30Z

@pelord ready for your review

pelord

J'ai cette erreur.

…ice to see in the map

aziz-access · 2024-11-19T15:44:37Z

J'ai cette erreur.

modifier l'option showSearchButton true dans config.json

 "searchBar": {
    "showSearchBar": true,
    "showSearchButton": true
  },

Il faut ajouter l'input map dans le composant <igo-search-bar> portal component (igo2).

packages/geo/src/lib/search/search-bar/search-bar.component.ts

alecarn · 2024-11-26T15:24:00Z

@pelord, ready for review/test

pelord · 2024-12-04T15:31:40Z

pourquoi pas pousser dans next?

pelord

Clarifier comment gérer les resultats asynchrone? Les services qui sont plus lent? P-etre tester avec un debouncetime random entre 500 et 2000 ms?

pelord · 2024-12-04T15:57:19Z

packages/geo/src/lib/search/search-bar/search-bar.component.ts

+   * When the user clicks on the magnifying glass and
+   * this find the first object on the map
+   */
+  selectFirstElement() {


Qu'est-ce qui arrive si les résultats ne sont pas tous arrivés lorsque l'utilisateur clique le bouton?

rien ne s'est passé, s'il y a un résultat, le résultat avec le score le plus élevé sera mis en évidence

Mais disons q'un utilisateur clique sur le boutin ou fait enter, mais que seul des résultats partiels sont disponible?

Quelle est l'échelle relative comparable entre les résultats? Comment comparer des résultats? Regarde computeTermSimilarity

chaque résultat a un score donc en utilise le score pour la comparaison

Le score est-il comparable entre les services de recherche?

il faudrait idéalement que ce soit sur une échelle absolue et non pas relative, comme pour iCherche

le code existant bien tester avec iCherche, le résultats de recherche donne le même objet, donc le score existe si le résultat est une couche ou Feature.
existe-t-il un autre service où je peux tester?

pelord · 2024-12-04T16:01:36Z

packages/geo/src/lib/search/search-bar/search-bar.component.html

@@ -15,28 +15,33 @@
          : undefined
      "
      [value]="term$ | async"
+      (keydown.enter)="selectFirstElement()"


Est-ce que le keydown.enter ne devrait pas re-trigger la recherche également?

sélectionner le 1er résultat?

oui sélectionner le résultat avec le score le plus élevé

Je crois que enter devrait redéclancher la recherche.

MSPKarengeo requested review from alecarn January 24, 2024 22:33

MSPKarengeo added the enhancement New features and improvements // Nouvelles fonctionnalités et améliorations label Jan 25, 2024

aziz-access assigned MSPKarengeo Jan 25, 2024

aziz-access linked an issue Jan 25, 2024 that may be closed by this pull request

Recherche - Ajout de la loupe dans la barre de recherche (optionnel) infra-geo-ouverte/igo2#844

Open

alecarn requested changes Feb 5, 2024

View reviewed changes

alecarn mentioned this pull request Feb 6, 2024

Recherche ajout loupe #1183

Closed

5 tasks

alecarn changed the base branch from next to release/16.x February 29, 2024 18:18

alecarn requested changes Mar 5, 2024

View reviewed changes

packages/geo/src/lib/search/search-bar/search-bar.component.ts Outdated Show resolved Hide resolved

alecarn approved these changes Mar 11, 2024

View reviewed changes

alecarn requested a review from pelord March 11, 2024 20:00

alecarn added the ready to merge label Mar 11, 2024

pelord requested changes Mar 13, 2024

View reviewed changes

alecarn self-requested a review March 28, 2024 17:16

alecarn added not ready and removed ready to merge labels May 13, 2024

alecarn assigned aziz-access and unassigned MSPKarengeo Nov 14, 2024

karengeo added 6 commits November 14, 2024 16:58

feat(magnifying glass): insert magnifying glass in new version

8093275

feat(magnifying glass): modifs to the glass

58ddf57

feat(magnifying glass):modifs with mistakes

a3bc176

feat(magnifyng class):modifications selectFirstElement

ab5088f

feat(magnifying glass):use the magnifying glass to find the first cho…

f52d806

…ice to see in the map

fix(magnifying glass):validation sur la longueur du tableau

10db31b

aziz-access force-pushed the nv_search_first_element_by_magnifying_glass branch from 8b4451e to 10db31b Compare November 14, 2024 16:04

perf: code improvement

aba0e07

aziz-access requested a review from pelord November 19, 2024 16:02

style: remove console log

27bea56

alecarn requested changes Nov 21, 2024

View reviewed changes

packages/geo/src/lib/search/search-bar/search-bar.component.ts Show resolved Hide resolved

fix: handle map if exist

59e1d6b

alecarn force-pushed the nv_search_first_element_by_magnifying_glass branch from 25a67af to 745f5cf Compare November 26, 2024 15:22

alecarn approved these changes Nov 26, 2024

View reviewed changes

alecarn added ready to merge and removed not ready labels Nov 26, 2024

feat(geo): search-bar add the magnifying glass

754da18

alecarn force-pushed the nv_search_first_element_by_magnifying_glass branch from 745f5cf to 754da18 Compare November 26, 2024 15:29

aziz-access added 3 commits December 2, 2024 16:09

fix(geo): check the result before analysis

a0fcf94

wip

2ef34bf

fix: merge branch 'nv_search_first_element_by_magnifying_glass'

c1b8736

pelord reviewed Dec 4, 2024

View reviewed changes

pelord added awaiting response and removed ready to merge labels Dec 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(magnifying glass): use the magnifying glass to find the first choice to see on the map #1600

feat(magnifying glass): use the magnifying glass to find the first choice to see on the map #1600

MSPKarengeo commented Jan 24, 2024

alecarn commented Feb 5, 2024 •

edited by MSPKarengeo

Loading

MSPKarengeo commented Feb 20, 2024

alecarn left a comment

alecarn commented Mar 11, 2024

pelord left a comment

aziz-access commented Nov 19, 2024 •

edited

Loading

alecarn commented Nov 26, 2024

pelord commented Dec 4, 2024

pelord left a comment

pelord Dec 4, 2024

aziz-access Dec 4, 2024

pelord Dec 4, 2024

aziz-access Dec 4, 2024

pelord Dec 4, 2024

pelord Dec 4, 2024

aziz-access Dec 4, 2024

pelord Dec 4, 2024

pelord Dec 4, 2024

pelord Dec 4, 2024

aziz-access Dec 4, 2024

pelord Dec 4, 2024

feat(magnifying glass): use the magnifying glass to find the first choice to see on the map #1600

Are you sure you want to change the base?

feat(magnifying glass): use the magnifying glass to find the first choice to see on the map #1600

Conversation

MSPKarengeo commented Jan 24, 2024

alecarn commented Feb 5, 2024 • edited by MSPKarengeo Loading

MSPKarengeo commented Feb 20, 2024

alecarn left a comment

Choose a reason for hiding this comment

alecarn commented Mar 11, 2024

pelord left a comment

Choose a reason for hiding this comment

aziz-access commented Nov 19, 2024 • edited Loading

alecarn commented Nov 26, 2024

pelord commented Dec 4, 2024

pelord left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alecarn commented Feb 5, 2024 •

edited by MSPKarengeo

Loading

aziz-access commented Nov 19, 2024 •

edited

Loading