fix(overlay): avoid calling push in iterable object to avoid error lo… #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandrofernandezcanton
requested review from
tlouisse,
daKmoR,
gerjanvangeest,
erikkroes,
ruphin,
narzac,
Knorgias,
whenlit and
DannyMoerkerke
as code owners
🦋 Changeset detectedLatest commit: 7cee3e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
alejandrofernandezcanton
force-pushed
the
fix/overlays-utils-adopt-styles
branch
from
d1a4cfc to
2edabb5
Compare
alejandrofernandezcanton
force-pushed
the
fix/overlays-utils-adopt-styles
branch
from
2edabb5 to
7cee3e7
Compare
gerjanvangeest
approved these changes
Oct 17, 2023
|
@gerjanvangeest thanks for merging the fix. Could you tell me when the next release will be? |
|
We normally do it on request, so i just created the release :) |
|
Thanks you @gerjanvangeest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ading overlays
What I did
Change .push in iterator to avoid error loading overlays. This only happens in old chromium version but we support old versions.
Resolves #2086