Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] auto detect hostname for remote preview #29

Merged
merged 1 commit into from
May 20, 2016

Conversation

LeaYeh
Copy link
Contributor

@LeaYeh LeaYeh commented Sep 26, 2015

auto detect host from browser's URL to create web socket instead of fixed localhost
Issue: #28

@hallzy
Copy link

hallzy commented May 19, 2016

I would like to try this, but I am not super familiar with any of this. I made the change in the index.html file but I am not sure what else I need to do to get this working. Just changing the line did not work for me so I guess I need to also do something else but I don't know what that is.

@hallzy
Copy link

hallzy commented May 19, 2016

I ended up just forking it and rerunning the command and that seemed to work. If you have a better way let me know. Thanks for this line change though :)

@suan
Copy link
Collaborator

suan commented May 20, 2016

@LeaYeh Thanks! This is a simple and elegant change and shouldn't break anything, so I'll be merging.

But to clarify, you had to make some changes similar to hallzy@8702f89 to prevent the initial window from opening on the machine, for this to work at all, right?

@suan suan merged commit 441d67c into instant-markdown:master May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants