Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Ubuntu 24.04 #1106

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Support for Ubuntu 24.04 #1106

merged 2 commits into from
Sep 6, 2024

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Sep 5, 2024

No description provided.

klihub
klihub previously approved these changes Sep 5, 2024
View reviewed changes
@askervin
Copy link
Contributor

askervin commented Sep 5, 2024

It seems e2e tests fail on Ubuntu 24.04 due to container stop failure. From cri-resmgr.output.txt in vm:

E: [resource-manager] StopContainer: failed to stop container pod0:pod0c1: rpc error: code = Unknown desc = failed to stop container "97e4401acd43cba20543030364eb9986d579a886d5c9af5973cda5f2a3a24ae8": unknown
 error after kill: runc did not terminate successfully: exit status 1: unable to signal init: permission denied

I don't know if it has anything to do with cri-resmgr. Fails both topology-aware and balloons tests in the first kubectl delete pod ... command.

askervin
askervin previously approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@askervin
Copy link
Contributor

askervin commented Sep 5, 2024

Approved as it has nothing to do with this patch, either. I'm fine merging this patch and debugging/fixing the issue later.

There is no problem in latest Ubuntu 22.04.

@klihub
Copy link
Contributor

klihub commented Sep 5, 2024

It seems e2e tests fail on Ubuntu 24.04 due to container stop failure. From cri-resmgr.output.txt in vm:

E: [resource-manager] StopContainer: failed to stop container pod0:pod0c1: rpc error: code = Unknown desc = failed to stop container "97e4401acd43cba20543030364eb9986d579a886d5c9af5973cda5f2a3a24ae8": unknown
 error after kill: runc did not terminate successfully: exit status 1: unable to signal init: permission denied

I don't know if it has anything to do with cri-resmgr. Fails both topology-aware and balloons tests in the first kubectl delete pod ... command.

I'm guessing something SELinux-related, maybe... Probably failure to disable or set to permissive mode during node spinup ?

@marquiz marquiz dismissed stale reviews from askervin and klihub via 8fac584 September 5, 2024 13:05
@marquiz
Copy link
Contributor Author

marquiz commented Sep 5, 2024

I'm guessing something SELinux-related, maybe

Does the latest ubuntu have SELinux enabled?

@klihub
Copy link
Contributor

klihub commented Sep 5, 2024

I'm guessing something SELinux-related, maybe

Does the latest ubuntu have SELinux enabled?

Argh... No, sorry, of course it does not. I was still in the context of the previous fedora-related PR I reviewed.

@klihub
Copy link
Contributor

klihub commented Sep 5, 2024

But this might be the cause: containerd/containerd#10542

@marquiz
Dockerfiles: change generic USER_OPTIONS build arg to USER_UID
adf640d 
We only pass user id to the builder image. We need to know the uid to
avoid clashes (for ubuntu 24.04 at least).
@marquiz
Support for Ubuntu 24.04
890a0ce
@marquiz
Copy link
Contributor Author

marquiz commented Sep 6, 2024

Rebased. PTAL @klihub

@klihub klihub merged commit 2cf6141 into intel:master Sep 6, 2024
6 checks passed
@marquiz marquiz deleted the devel/ubuntu branch September 6, 2024 11:43
@marquiz marquiz mentioned this pull request Sep 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klihub klihub klihub approved these changes

@askervin askervin askervin left review comments

@kad kad Awaiting requested review from kad kad is a code owner

@mythi mythi Awaiting requested review from mythi mythi is a code owner

@fmuyassarov fmuyassarov Awaiting requested review from fmuyassarov fmuyassarov is a code owner

Assignees

@askervin askervin

@klihub klihub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marquiz @askervin @klihub