Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update the govm setup instructions #1110

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Sep 5, 2024

We're not compatible with the latest govm.

@marquiz
Copy link
Contributor Author

marquiz commented Sep 5, 2024

After fighting with this on a fresh dev machine I decided to update the docs...

@klihub
Copy link
Contributor

klihub commented Sep 6, 2024

I again mixed up PRs. My following comment the other day was about this PR, so I repeat it here:

It is this commit which breaks govm for us. With that commit in place I see docker log messages which suggest that the content of cloud-init user-data is also being interpreted as a/the docker volume specification...

Copy link
Contributor

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@marquiz
Copy link
Contributor Author

marquiz commented Sep 10, 2024

ping @askervin @klihub

@klihub
Copy link
Contributor

klihub commented Sep 10, 2024

ping @askervin @klihub

I'm fine with this if we get the lost job running and the CI test to pass so we can merge this.

@marquiz
Copy link
Contributor Author

marquiz commented Sep 10, 2024

verify / build-and-test is not run for docs-only PR. I don't understand why it picked that in this PR

@marquiz marquiz closed this Sep 10, 2024
@marquiz marquiz reopened this Sep 10, 2024
We're not compatible with the latest govm.
@klihub klihub closed this Sep 10, 2024
@klihub klihub reopened this Sep 10, 2024
@klihub klihub merged commit 97e8dd8 into intel:master Sep 10, 2024
10 of 12 checks passed
@marquiz marquiz deleted the devel/govm branch September 10, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants