Interlink: optimize rebalance #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes the slow loops that rebalance the packet freelists. This change might not be worth the code: while it significantly reduces the latency of rebalancing operations (as observed using the timeline) in micro benchmarks, it does not have measurable impact on more realistic benchmarks like Vita’s
test.snabb, likely due to the fact that duplex packet flow avoids most of the need to rebalance freelists at all.Notably, when testing this change using Vita’s
test.snabba performance regression was observed, possibly due to 8f5569b (alignment?). Have do dig into that in case this optimization becomes relevant.