Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify connection workflow #14

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Simplify connection workflow #14

wants to merge 35 commits into from

Conversation

gjsjohnmurray
Copy link
Collaborator

This PR closes #6

@isc-rsingh
Copy link
Member

@gjsjohnmurray do you want me to test this before approving?

@gjsjohnmurray gjsjohnmurray marked this pull request as draft November 15, 2024 22:00
@gjsjohnmurray
Copy link
Collaborator Author

@isc-rsingh yes, please hold off until I get the CI building VSIXes. It's complicated because platform-specific builds are required. I hope to have something for you early-mid next week.

@gjsjohnmurray gjsjohnmurray marked this pull request as ready for review November 18, 2024 13:10
@gjsjohnmurray
Copy link
Collaborator Author

@isc-rsingh the platform-specific VSIXes for this PR are now available at https://github.com/intersystems-community/vscode-iris-jupyter-server/actions/runs/11893095951

@gjsjohnmurray
Copy link
Collaborator Author

@isc-rsingh looking forward to your feedback on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt JupyterServerProvider API to simplify connection workflow
2 participants