-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Route Synchronizer is not multi-worker-safe #30
Comments
Testing with |
Cc: @alkesh |
In limited testing, it seems to be ok when running in single worker mode: |
Firefishy
changed the title
Route Synchronizer is not threadsafe
Route Synchronizer is not multiwork-safe
Apr 16, 2018
Firefishy
changed the title
Route Synchronizer is not multiwork-safe
Route Synchronizer is not multi-worker-safe
Apr 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The route Synchronizer is not threadsafe and fails to consistently reload routes across threads.
Test case:
ab -c 20 -n 200000 http://URL-FOR-MOCK-A
Expected:
Routes reload as expected.
Observed:
Routes do not load consistently across some app threads and app throws errors due to missing routes.
(PR brewing)
The text was updated successfully, but these errors were encountered: