Simplify route reloader and ensure threadsafe #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heavily inspired by: https://stackoverflow.com/questions/48506247/rails-reload-dynamic-routes-on-multiple-instances-servers Avoid using Application State and use Rails.cache for Route reload state.
|
CC: @alkesh would you mind reviewing? I am a rails newbie. |
|
@Firefishy I can help with this when I find some time if you haven't pushed a fix. |
|
I'll likely need some help fixing the broken tests. I might get some help from my colleague @alkesh today. |
|
Fail :-( I am out of my depth. Beyond the broken tests, my changes do not work for workers. Likely needs some fixes to Rack middleware and this is beyond my ability. |
|
No worries. Feel free to close this PR. I will open an issue (or you if you prefer) to note what you noticed about thread safety for future investigation. Thank you very much for your work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heavily inspired by: https://stackoverflow.com/questions/48506247/rails-reload-dynamic-routes-on-multiple-instances-servers
Avoid using Application State and use Rails.cache for Route reload state.
Fix: #30