feat: enhance query builder with improved alias handling #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `quote` function to handle SQL expressions with aliases more robustly. - Added support for quoting function expressions like `COUNT(id) as count` and `MAX(id) as maxId`. - Improved test coverage by adding a test case for `select count` in both v1 and v2 test suites. - Ensured consistent quoting of standalone identifiers and expressions in query generation. This change improves the flexibility and correctness of SQL query generation, particularly in handling complex expressions with aliases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quotefunction to handle SQL expressions with aliases more robustly.COUNT(id) as countandMAX(id) as maxId.select countin both v1 and v2 test suites.This change improves the flexibility and correctness of SQL query generation, particularly in handling complex expressions with aliases.