Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the root .travis.yml file into a GitHub Actions workflow #215

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

kyluca
Copy link
Contributor

@kyluca kyluca commented Oct 30, 2024

Implements #214.

Hopefully this is in line with what you were looking for @jacebrowning?

  • It should be roughly the same as the Travis script except for the second clone operation which I moved out into a dedicated step of its own using a native GHA action instead of a raw git clone.
  • I've also deferred the deletion of the old .travis.yml file to leave an overlap period where you can verify the new workflow is working as expected before disabling Travis.
  • I'm not sure if I can effectively test the demo repo integration from my fork, so it might be best to try the workflow from the original repo as well, hoping the default built-in tokens have the right scopes and permissions etc.

Let me know if there's anything I've missed :)

@jacebrowning jacebrowning self-requested a review October 30, 2024 19:30
# Configure Git with GHA information, for more info see:
# https://github.com/actions/checkout?tab=readme-ov-file#push-a-commit-using-the-built-in-token
git config user.name "github-actions[bot]"
git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this value come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the unique user ID of the official GHA bot account, taken from the link I put as a comment on L48: https://github.com/actions/checkout?tab=readme-ov-file#push-a-commit-using-the-built-in-token

That doc in turn references the user ID directly from the GH API https://api.github.com/users/github-actions%5Bbot%5D.

Here's another discussion which may explain better: https://github.com/orgs/community/discussions/26560#discussioncomment-3252340

@jacebrowning jacebrowning merged commit 9c842a7 into jacebrowning:main Nov 1, 2024
@jacebrowning
Copy link
Owner

I'm trying to figure out how to make the token work here: #216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants