Skip to content
This repository has been archived by the owner on Jul 30, 2020. It is now read-only.

[READY] Drop hardcoded standard includes #643

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bstaletic
Copy link
Contributor

With clang -E -v trick for getting system include paths, the hardcoded includes are redundant.
Besides this, the hardcoded includes can often be wrong - depending on the project settings.

@jacobdufault
Copy link
Owner

jacobdufault commented Apr 23, 2018

Looks like CMakeLists.txt needs to be updated.

Does cquery still suggest <vector>? I suspect it does not, because the path does not pass the suffix filter.

@bstaletic bstaletic force-pushed the drop_standard_includes branch from 611bc5f to 1240786 Compare April 23, 2018 19:33
@bstaletic
Copy link
Contributor Author

Fixed CMake.
<vector> doesn't get suggested according to my quick test.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants