Make time provider independent of PWM abstraction #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since a platform can have multiple PWM-HALs (e.g. the one provided by the platform, and additional ones like e.g. a PCA9685 HAL), but only a single time provider, the code was split. Each platform now has it's own time providing class, like e.g. `class ArduinoClock`. An implementation consists of a single static method: `static uint32_t millis()` that returns the current time in millis.
jandelgado
force-pushed
the
make_time_provider_independent_of_pwm_abstraction
branch
from
f24cdb2 to
de5d87b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move time providing function to separate class.
Since a platform can have multiple PWM-HALs (e.g. the one provided by
the platform, and additional ones like e.g. a PCA9685 HAL), but only
a single time provider, the code was split.
Each platform now has it's own time providing class, like e.g.
class ArduinoClock. An implementation consists of asingle static method:
static uint32_t millis()that returns thecurrent time in millis.
This introduces a breaking change when client code uses a custom HAL.