Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for filename template values #484

Conversation

jerinpetergeorge
Copy link
Contributor

Type of PR - Enhancement

Description

This PR will check whether the values of DBBACKUP_FILENAME_TEMPLATE and DBBACKUP_MEDIA_FILENAME_TEMPLATE contains any "slashes" (/) in it (Ref: #479 ).

Why should this be added

If the filename contains slashes, the storage will create a directory out of it and the --clean flag won't work as expected.

@Archmonger
Copy link
Contributor

Blocked on #483

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (765a75d) 91.21% compared to head (dd5eaf6) 91.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
+ Coverage   91.21%   91.33%   +0.12%     
==========================================
  Files          19       19              
  Lines         854      866      +12     
  Branches      150      152       +2     
==========================================
+ Hits          779      791      +12     
  Misses         40       40              
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archmonger
Copy link
Contributor

Archmonger commented Jan 29, 2024

@jerinpetergeorge Can you update the hint to also suggest changing location?

Maybe adding another sentence like Did you mean to change DBBACKUP_STORAGE_OPTIONS['location']?

I'm not sure if there's an equivalent for media storage?

This PR can be merged after that.

@Archmonger Archmonger linked an issue Jan 29, 2024 that may be closed by this pull request
@Archmonger Archmonger merged commit b0fdd24 into jazzband:master Aug 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"--clean" flag not working as expected
2 participants