Fix #148 single source of truth for the changelog #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphrak
reviewed
Jan 17, 2019
| -w $MOUNT_FOLDER \ | ||
| -p $MKDOCS_DEV_PORT:$MKDOCS_DEV_PORT \ | ||
| -e MKDOCS_DEV_ADDR="$MKDOCS_DEV_ADDR:$MKDOCS_DEV_PORT" \ | ||
| squidfunk/mkdocs-material:3.2.0 $* |
There was a problem hiding this comment.
Just making sure, $* is intended yes?
There was a problem hiding this comment.
Yes sure it is :-)
belugame
reviewed
Jan 17, 2019
|
|
||
| It will run mkdocs in a [docker](https://www.docker.com/) container. | ||
|
|
||
| Running the script without any params the `serve` command. |
There was a problem hiding this comment.
This sentence doesn't quite make sense to me grammatically 🤔
belugame
reviewed
Jan 17, 2019
|
|
||
| Running the script without any params the `serve` command. | ||
| The server is exposed on localhost on port 8000. | ||
| If you want to configure port serve is exposed on you can use the |
There was a problem hiding this comment.
Here I'm also not sure.. should it be "if you want to configure a port where the server is exposed on?
|
awesome work! thank you very much! :) |
|
I will look at the grammar issues, did that while speaking to my wife, I may have missed some stuff 😄 |
dontexit
pushed a commit
to dontexit/django-rest-knox
that referenced
this pull request
Jan 24, 2024
Fix jazzband#148 single source of truth for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #148 by making
CHANGELOG.mdthe only source of truth for the doc.It is achieved by symlinking it in the
docsfolder.I added a docker utility to work on the doc + documentation in the README on how to build the doc (doc for doc 🙄)
Also fixed an easy deprecation warning in mkdocs.