Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume text & Volume markers in Mixer View, Volume Callback #11

Open
wants to merge 39 commits into
base: master
Choose a base branch
from

Conversation

brummbrum
Copy link
Contributor

Based on pull request #10 as it uses functions introduced there, namely the calibrated meter conversion to set the volume marker precisely matched to the labels in both the KK keyboard display and Reaper's meters.
Volume text matches meter readings correctly.

Immediate display updates for volume as we are (slowly) moving out of the "abusive" call to update the entire bank from within track selection change.

Leonard de Ruijter and others added 30 commits April 24, 2019 07:06
Direct track selection in Mixer view w top row buttons
Mixer Mode Track Navigation
Comments for future changes. Branch from here as this modifies architecture an multiple areas
Direct API calls for track selection rather than Reaper actions to overcome 99 track limit
Track selection working
Non existing tracks in last bank are now properly marked as not available
VU meter data format ok, but:
- Need a better hook (update frequency)
- VU meter updates not working properly. CMD_SEL_TRACK_PARAMS_CHANGED not fully understood yet
VU:
- functionality is there!
- some minor tweaks like scaling still open
- code cleanup required
native conversion taken from Reaper SDK
- Calibration also valid for other keyboards than S Mk2?
-Meters working
-Precise, non linear calibration for KK Mk2 Display Meters
- Stub to isolate this pull request from fork master
brummbrum added 9 commits May 20, 2019 12:59
efficiency improvement
- Use direct linear logarithmic conversion specifc to NI keyboard meter scaling rather than concatenating a calibration frunction after calling Reaper API standard conversions
- Speed improvement
- Further meter precision improvement
- linear approximation f meter between -48dB and -96dB
- code simplification in peakMixerUpdate
minus96dB and code simplification
- incl editiorial changes (comments, function names, variable names) for a clearer understanding
@brummbrum
Copy link
Contributor Author

while reading through some of Reaper's API functions I came across these two beauties:
mkvolstr
mkpanstr
-> It seems I may have coded the vol to ASCII string function unnecessarily since we can use the built in service conveniently. The result will be the same but the code will look leaner if we use the built in stuff whenever possible. Will test and update as a package when I do the Panorama text, marker and callback.

jcsteh pushed a commit that referenced this pull request Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant