fix(uploader): 修复选择多个文件上传只会上传一个文件的问题 Fixes #2549

[zhuddan]

修复#2549

• 修复了 readFile 方法中多文件处理的缺陷
• 调整文件读取逻辑，确保所有选中的文件都能正确处理

🤔 这个变动的性质是？

• 新特性提交
• 日常 bug 修复
• 站点、文档改进
• 演示代码改进
• 组件样式/交互改进
• TypeScript 定义更新
• 包体积优化
• 性能优化
• 功能增强
• 国际化改进
• 重构
• 代码风格优化
• 测试用例
• 分支合并
• 其他改动（是关于什么的改动？）

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

• 文档已补充或无须补充
• 代码演示已提供或无须提供
• TypeScript 定义已补充或无须补充
• fork仓库代码是否为最新避免文件冲突
• Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

• 新功能

  • 优化了文件上传组件的文件处理逻辑，提高了状态管理效率。
  • 增强了文件大小验证，确保超大文件被过滤，并触发相应回调。
  • 改进了文件删除流程，增加了删除前的回调控制。

• 修复

  • 精简了文件项的状态更新逻辑，确保上传进度和结果的状态及时更新。

[coderabbitai]

Walkthrough

该拉取请求对 Uploader 组件进行了多项修改，主要集中在 src/packages/uploader/uploader.taro.tsx 和 src/packages/uploader/uploader.tsx 文件中。引入了一个新的 results 变量来累积文件项，优化了状态更新的逻辑，减少了对 setFileList 的调用次数。同时，更新了文件过滤功能，以更有效地处理文件大小验证，并在文件超出最大限制时触发回调。整体控制流保持不变，主要聚焦于提升文件项处理的效率。

Changes

文件路径	更改摘要
src/packages/uploader/uploader.taro.tsx	- 在 readFile 函数中添加了 results 变量以累积 FileItem 实例。 - 优化了 fileList 状态更新，减少了调用次数。 - 更新了 filterFiles 函数以处理文件大小验证。 - 简化了文件上传过程中的状态和消息更新。
src/packages/uploader/uploader.tsx	- 在 readFile 函数中声明了 results 变量以累积文件项。 - 修改了 onDeleteItem 函数以包含 funcInterceptor 调用，增强了删除流程的控制。

Possibly related PRs

• fix(uploader): 京东小程序中可上传时可选择图片和视频 #2410: 修改了 uploader.taro.tsx 文件中的媒体源选择逻辑，与主 PR 中的文件上传处理相关。
• fix(uploader): pre-upload pmage preview bug  #2416: 更新了 uploader.taro.tsx 文件，专注于 fileList 和 uploadQueue 的管理，与主 PR 中的状态更新相关。
• fix(uploader): images should display when they've been successfully uploaded  #2448: 提升了 uploader.taro.tsx 文件中的文件上传过程，改善了文件上传状态管理的逻辑，直接与主 PR 中的更改相关。
• feat(uploader): support beforeupload props in taro #2567: 在 uploader.taro.tsx 中引入了新的 beforeUpload 属性，修改了文件上传的控制流程，与主 PR 中的文件处理和状态管理相关。

Suggested reviewers

• oasis-cloud

兔子欢快跳跃，
文件上传更顺畅，
状态更新如春风，
大小验证不再慌。
让我们一起庆祝，
代码更美好，心情更亮！ 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

src/packages/uploader/uploader.taro.tsx (2)

390-390: 多端文件上传状态管理优化！

改动与Web版本保持一致，通过 results 数组优化了状态更新逻辑。建议考虑添加以下改进：

 const readFile = <T extends TFileType>(files: T[]) => {
   const results: FileItem[] = []
+  // 添加文件总数的日志，便于调试
+  console.debug(`Processing ${files.length} files`)
   files.forEach((file: T, index: number) => {

Also applies to: 432-432, 434-434

---

Line range hint 437-455: 建议添加单元测试覆盖文件过滤逻辑

filterFiles 函数包含重要的业务逻辑，建议添加单元测试以确保：

1. 文件大小过滤功能
2. 最大文件数限制
3. onOversize 回调触发

需要我帮助生成相关的单元测试代码吗？

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between a767209 and a3251a2.

📒 Files selected for processing (2)

• src/packages/uploader/uploader.taro.tsx (2 hunks)
• src/packages/uploader/uploader.tsx (2 hunks)

🧰 Additional context used

📓 Learnings (1)

src/packages/uploader/uploader.taro.tsx (1)

Learnt from: Alex-huxiyang
PR: jdf2e/nutui-react#2416
File: src/packages/uploader/uploader.taro.tsx:230-230
Timestamp: 2024-11-12T04:18:14.418Z
Learning: When changes are made to the `fileList` state in the `src/packages/uploader/uploader.taro.tsx` file, ensure to generate unit tests to cover these changes.

🔇 Additional comments (1)

src/packages/uploader/uploader.tsx (1)

291-291: 优化了文件上传状态管理逻辑！

通过引入 results 数组来累积文件项，并在所有文件处理完成后一次性更新状态，这样的改动：

1. 避免了多文件上传时的竞态条件
2. 减少了不必要的状态更新
3. 提高了代码的可维护性

Also applies to: 310-311, 315-315, 318-318

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.06%. Comparing base (a767209) to head (a3251a2).
Report is 5 commits behind head on next.

Files with missing lines	Patch %	Lines
src/packages/uploader/uploader.tsx	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #2807      +/-   ##
==========================================
- Coverage   84.07%   84.06%   -0.01%     
==========================================
  Files         217      217              
  Lines       17830    17832       +2     
  Branches     2609     2609              
==========================================
  Hits        14991    14991              
- Misses       2834     2836       +2     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.