Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 构建全量 css 文件 #2891

Closed
wants to merge 15 commits into from

Conversation

oasis-cloud
Copy link
Collaborator

@oasis-cloud oasis-cloud commented Dec 26, 2024

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • 新功能

    • 新增 Lottie 组件,支持加载动画。
    • 更新 Loading 组件,支持 Lottie 动画。
    • 引入新的 PullToRefresh 组件动画,替换原有图标为 Lottie 动画。
  • 文档

    • Lottie 组件添加了详细文档,包括属性和方法说明。
  • 样式

    • 新增 $loading-lottie-background 变量以支持 Lottie 动画的背景色自定义。
  • 修复

    • 更新 PullToRefresh 组件的 headHeight 属性,使其动态计算。

Copy link

coderabbitai bot commented Dec 26, 2024

Caution

Review failed

The pull request is closed.

概述

代码变更概览

本次拉取请求(PR)引入了多个重要的变更,主要涉及依赖管理、Lottie 动画组件的引入以及相关文档和测试的更新。主要变更包括:

代码变更详情

依赖管理

  • package.json 中添加了 lottie-miniprogramlottie-react 依赖
  • 重新引入了 @tarojs/plugin-platform-weapp 依赖
  • 更新了多个依赖的解析版本

新组件引入

  • 添加了 Lottie 动画组件,支持在不同平台(Web 和小程序)渲染动画
  • 新增了多个 Lottie 动画 JSON 文件,包括加载、全局和下拉刷新动画

测试和配置

  • 更新了 Vitest 测试配置
  • 添加了 Canvas 模拟支持

详细变更

代码走查

本次拉取请求主要关注依赖管理和 Lottie 动画组件的引入。通过添加新的依赖和组件,项目增强了动画展示能力,并改进了跨平台兼容性。变更涉及多个文件,包括配置文件、组件实现和文档。

变更

文件路径 变更摘要
package.json 添加 Lottie 相关依赖,更新依赖解析
src/config.json 新增 Lottie 组件配置
src/packages/loading/* 更新 Loading 组件以支持 Lottie 动画
src/packages/lottie/* 新增 Lottie 组件实现和动画文件
src/styles/variables.scss 新增 Lottie 加载背景变量

建议标签

size/XXL, 3.x

相关拉取请求

诗歌

🐰 动画兔子轻轻跳,
Lottie 魔法随风飘,
加载图标闪闪亮,
代码之路更精妙,
兔子笑看新版本!🌈


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f764c71 and bd81d44.

⛔ Files ignored due to path filters (8)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
  • src/packages/lottie/animation/dark/global.gif is excluded by !**/*.gif
  • src/packages/lottie/animation/dark/loading.gif is excluded by !**/*.gif
  • src/packages/lottie/animation/dark/pulltorefresh-white.gif is excluded by !**/*.gif
  • src/packages/lottie/animation/dark/pulltorefresh.gif is excluded by !**/*.gif
  • src/packages/lottie/animation/light/global.gif is excluded by !**/*.gif
  • src/packages/lottie/animation/light/loading.gif is excluded by !**/*.gif
  • src/packages/lottie/animation/light/pulltorefresh.gif is excluded by !**/*.gif
📒 Files selected for processing (54)
  • package.json (3 hunks)
  • packages/nutui-taro-demo/package.json (0 hunks)
  • src/config.json (2 hunks)
  • src/packages/configprovider/types.ts (3 hunks)
  • src/packages/loading/__test__/loading.spec.tsx (2 hunks)
  • src/packages/loading/demos/h5/demo1.tsx (1 hunks)
  • src/packages/loading/demos/taro/demo1.tsx (1 hunks)
  • src/packages/loading/demos/taro/demo8.tsx (2 hunks)
  • src/packages/loading/doc.en-US.md (0 hunks)
  • src/packages/loading/doc.md (0 hunks)
  • src/packages/loading/doc.taro.md (0 hunks)
  • src/packages/loading/doc.zh-TW.md (1 hunks)
  • src/packages/loading/index.taro.ts (1 hunks)
  • src/packages/loading/index.ts (1 hunks)
  • src/packages/loading/loading.scss (1 hunks)
  • src/packages/loading/loading.taro.tsx (2 hunks)
  • src/packages/loading/loading.tsx (2 hunks)
  • src/packages/loading/types.ts (1 hunks)
  • src/packages/lottie/animation/dark/global.json (1 hunks)
  • src/packages/lottie/animation/dark/loading.json (1 hunks)
  • src/packages/lottie/animation/dark/pulltorefresh-white.json (1 hunks)
  • src/packages/lottie/animation/dark/pulltorefresh.json (1 hunks)
  • src/packages/lottie/animation/light/global.json (1 hunks)
  • src/packages/lottie/animation/light/loading.json (1 hunks)
  • src/packages/lottie/animation/light/pulltorefresh.json (1 hunks)
  • src/packages/lottie/demo.taro.tsx (1 hunks)
  • src/packages/lottie/demo.tsx (1 hunks)
  • src/packages/lottie/demos/h5/demo1.tsx (1 hunks)
  • src/packages/lottie/demos/h5/demo2.tsx (1 hunks)
  • src/packages/lottie/demos/h5/demo3.tsx (1 hunks)
  • src/packages/lottie/demos/taro/demo1.tsx (1 hunks)
  • src/packages/lottie/demos/taro/demo2.tsx (1 hunks)
  • src/packages/lottie/demos/taro/demo3.tsx (1 hunks)
  • src/packages/lottie/doc.en-US.md (1 hunks)
  • src/packages/lottie/doc.md (1 hunks)
  • src/packages/lottie/doc.taro.md (1 hunks)
  • src/packages/lottie/doc.zh-TW.md (1 hunks)
  • src/packages/lottie/index.taro.ts (1 hunks)
  • src/packages/lottie/index.ts (1 hunks)
  • src/packages/lottie/mp.taro.tsx (1 hunks)
  • src/packages/lottie/types.ts (1 hunks)
  • src/packages/lottie/web.taro.tsx (1 hunks)
  • src/packages/lottie/web.tsx (1 hunks)
  • src/packages/pulltorefresh/demos/h5/demo1.tsx (2 hunks)
  • src/packages/pulltorefresh/demos/h5/demo2.tsx (3 hunks)
  • src/packages/pulltorefresh/demos/taro/demo1.tsx (2 hunks)
  • src/packages/pulltorefresh/demos/taro/demo3.tsx (2 hunks)
  • src/packages/pulltorefresh/pulltorefresh.scss (1 hunks)
  • src/packages/pulltorefresh/pulltorefresh.taro.tsx (1 hunks)
  • src/packages/pulltorefresh/pulltorefresh.tsx (1 hunks)
  • src/styles/variables.scss (1 hunks)
  • src/utils/platform-taro.ts (1 hunks)
  • vite.config.ts (1 hunks)
  • vitest.setup.ts (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.89%. Comparing base (e7b36cf) to head (bd81d44).
Report is 17 commits behind head on feat_v3.x.

Additional details and impacted files
@@              Coverage Diff              @@
##           feat_v3.x    #2891      +/-   ##
=============================================
+ Coverage      84.56%   85.89%   +1.32%     
=============================================
  Files            273      273              
  Lines          18609    18449     -160     
  Branches        2693     2729      +36     
=============================================
+ Hits           15737    15847     +110     
+ Misses          2867     2597     -270     
  Partials           5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant