-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(textarea): 字数限制文本遮挡输入框的内容 #2910
Conversation
概述演练此拉取请求主要更新了 TextArea 组件的文档和样式。在多个语言版本的文档中添加了新的 CSS 变量 变更
可能相关的 PR
建议标签
建议审阅者
诗歌
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2910 +/- ##
=======================================
Coverage 84.02% 84.02%
=======================================
Files 220 220
Lines 17917 17917
Branches 2628 2628
=======================================
Hits 15055 15055
Misses 2857 2857
Partials 5 5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/packages/textarea/textarea.scss (1)
2-3
: 布局调整解决了字数限制文本遮挡问题通过将布局方式从绝对定位改为 flex 布局,并使用
flex-direction: column
确保字数限制文本正确放置在内容下方,解决了遮挡问题。同时新增的text-align
属性提供了更灵活的对齐方式控制。建议考虑添加一个小的间距,以优化视觉效果:
&-limit { font-size: $textarea-font; color: $textarea-limit-color; + margin-top: 4px; text-align: $textarea-limit-align; }
Also applies to: 22-22
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
src/packages/textarea/doc.en-US.md
(1 hunks)src/packages/textarea/doc.md
(1 hunks)src/packages/textarea/doc.taro.md
(1 hunks)src/packages/textarea/doc.zh-TW.md
(1 hunks)src/packages/textarea/textarea.scss
(2 hunks)src/styles/variables.scss
(1 hunks)
🔇 Additional comments (5)
src/packages/textarea/doc.zh-TW.md (1)
109-109
: 文档更新清晰完整新增的 CSS 变量
--nutui-textarea-limit-align
文档说明完整,默认值设置合理。src/packages/textarea/doc.taro.md (1)
110-110
: 文档保持一致性Taro 版本的文档与其他语言版本保持一致,新增的 CSS 变量说明完整。
src/packages/textarea/doc.md (1)
110-110
: 文档更新准确且完整!新增的 CSS 变量
--nutui-textarea-limit-align
文档说明清晰,默认值设置合理。src/packages/textarea/doc.en-US.md (1)
110-110
: 英文文档同步更新正确!英文文档中新增的 CSS 变量说明与中文文档保持一致,翻译准确。
src/styles/variables.scss (1)
590-590
: 变量定义规范且实现正确!新增的 SCSS 变量
$textarea-limit-align
定义:
- 遵循项目命名规范
- 正确使用 CSS 自定义属性
- 提供合理的默认值
🤔 这个变动的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit
TextArea
组件添加了新的 CSS 变量--nutui-textarea-limit-align
,允许自定义字符限制显示的对齐方式。