Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(textarea): 字数限制文本遮挡输入框的内容 #2910

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

oasis-cloud
Copy link
Collaborator

@oasis-cloud oasis-cloud commented Jan 2, 2025

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • 新功能
    • TextArea 组件添加了新的 CSS 变量 --nutui-textarea-limit-align,允许自定义字符限制显示的对齐方式。
    • 默认情况下,字符限制文本将右对齐。

Copy link

coderabbitai bot commented Jan 2, 2025

概述

演练

此拉取请求主要更新了 TextArea 组件的文档和样式。在多个语言版本的文档中添加了新的 CSS 变量 --nutui-textarea-limit-align,用于控制字符限制显示的文本对齐方式。同时,在 textarea.scssvariables.scss 中进行了相应的样式调整,默认将字符限制文本对齐设置为右侧。

变更

文件路径 变更摘要
src/packages/textarea/doc.*.md 添加新的 CSS 变量 --nutui-textarea-limit-align,默认值为 right
src/packages/textarea/textarea.scss 调整布局和对齐属性,设置 text-align$textarea-limit-align
src/styles/variables.scss 新增变量 $textarea-limit-align,默认值为 var(--nutui-textarea-limit-align, right)

可能相关的 PR

建议标签

3.x

建议审阅者

  • xiaoyatong

诗歌

兔子轻跳,代码飞扬
文本对齐,右侧安详
CSS 变量,灵活自如
TextArea 焕然一新
代码如诗,优雅飞翔 🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.02%. Comparing base (9cfb6e9) to head (c63062e).
Report is 4 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2910   +/-   ##
=======================================
  Coverage   84.02%   84.02%           
=======================================
  Files         220      220           
  Lines       17917    17917           
  Branches     2628     2628           
=======================================
  Hits        15055    15055           
  Misses       2857     2857           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/packages/textarea/textarea.scss (1)

2-3: 布局调整解决了字数限制文本遮挡问题

通过将布局方式从绝对定位改为 flex 布局,并使用 flex-direction: column 确保字数限制文本正确放置在内容下方,解决了遮挡问题。同时新增的 text-align 属性提供了更灵活的对齐方式控制。

建议考虑添加一个小的间距,以优化视觉效果:

 &-limit {
   font-size: $textarea-font;
   color: $textarea-limit-color;
+  margin-top: 4px;
   text-align: $textarea-limit-align;
 }

Also applies to: 22-22

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9cfb6e9 and c63062e.

📒 Files selected for processing (6)
  • src/packages/textarea/doc.en-US.md (1 hunks)
  • src/packages/textarea/doc.md (1 hunks)
  • src/packages/textarea/doc.taro.md (1 hunks)
  • src/packages/textarea/doc.zh-TW.md (1 hunks)
  • src/packages/textarea/textarea.scss (2 hunks)
  • src/styles/variables.scss (1 hunks)
🔇 Additional comments (5)
src/packages/textarea/doc.zh-TW.md (1)

109-109: 文档更新清晰完整

新增的 CSS 变量 --nutui-textarea-limit-align 文档说明完整,默认值设置合理。

src/packages/textarea/doc.taro.md (1)

110-110: 文档保持一致性

Taro 版本的文档与其他语言版本保持一致,新增的 CSS 变量说明完整。

src/packages/textarea/doc.md (1)

110-110: 文档更新准确且完整!

新增的 CSS 变量 --nutui-textarea-limit-align 文档说明清晰,默认值设置合理。

src/packages/textarea/doc.en-US.md (1)

110-110: 英文文档同步更新正确!

英文文档中新增的 CSS 变量说明与中文文档保持一致,翻译准确。

src/styles/variables.scss (1)

590-590: 变量定义规范且实现正确!

新增的 SCSS 变量 $textarea-limit-align 定义:

  • 遵循项目命名规范
  • 正确使用 CSS 自定义属性
  • 提供合理的默认值

@xiaoyatong xiaoyatong merged commit c08d827 into jdf2e:next Jan 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants