feat: add option to disable parallel download #296
+53
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfroche
force-pushed
the
feat/disable-parallel-download
branch
from
e718db4 to
42cd0f7
Compare
Some provider fails to comply with s3 parallel downloads. Add an option to disable it http://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/s3/transfer/TransferManager.html#download(com.amazonaws.services.s3.model.GetObjectRequest,%20java.io.File,%20com.amazonaws.services.s3.transfer.internal.S3ProgressListener)
jfroche
force-pushed
the
feat/disable-parallel-download
branch
from
42cd0f7 to
dc2ffa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some provider fails to comply with s3 parallel downloads.
Add an option to disable it
http://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/s3/transfer/TransferManager.html#download(com.amazonaws.services.s3.model.GetObjectRequest,%20java.io.File,%20com.amazonaws.services.s3.transfer.internal.S3ProgressListener)
AWS announce of parallel download: https://aws.amazon.com/blogs/developer/parallelizing-large-downloads-for-optimal-speed/
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
All download are running in parallel. By parallel we mean the parts composing a file is downloaded in parallel.
What is the new behavior (if this is a feature change)?
If user enable the option, the download are not running in parallel
Behavior doesn't change if the user don't enable the option.
Does this PR introduce a breaking change? (What changes might users need to make in their setup due to this PR?)
No, it is just feature flag