Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename jerry_port_print_char to jerry_port_string_print for printing UTF8 directly #4860

Closed

Conversation

lygstate
Copy link
Contributor

@lygstate lygstate commented Dec 7, 2021

Use name jerry_port_string_print to consistence with jerry_string_print.
Add API jerry_string_iterate_code_point and jerry_code_point_print to be called by jerry_port_string_print

Followup of #4829

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo [email protected]

…UTF8 directly

Use name jerry_port_string_print to consistence with jerry_string_print.
Add API jerry_string_iterate_code_point and jerry_code_point_print to be called by jerry_port_string_print

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo [email protected]
@lygstate lygstate force-pushed the jerry_port_string_print branch from ebb72c2 to 6c61a5a Compare December 7, 2021 20:23
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If i get it right there was no agreement in #4829 about dropping jerry_port_print_char, rather than it should be kept but we can introduce jerry_port_string_print for convenience.
However @dbatyai is currently working on this topic, so be patient.

@lygstate
Copy link
Contributor Author

lygstate commented Dec 8, 2021

If i get it right there was no agreement in #4829 about dropping jerry_port_print_char, rather than it should be kept but we can introduce jerry_port_string_print for convenience. However @dbatyai is currently working on this topic, so be patient.

hi we have jerry_code_point_print do the same thing, anyway, I am looking on it

@dbatyai
Copy link
Member

dbatyai commented Dec 8, 2021

As I've said, and as @rerobika pointed out, this is not the right approach, jerry_port_print_char should not be removed, and jerry_code_point_print is not the same. I also don't see any reason to introduce the concept of code points to the api.

Also, as I've said before, I'm making a lot of changes to the entire port infrastructure, including how i/o is handled in jerry-ext and jerry-main, among many other things, and the changes present here are already incompatible. I do not wan't to merge anything that I would have to rewrite entirely in the next api revision patch, there's no reason for it.

Also, the debugger and port api interaction needs more thought to it than just slamming in new api functions.

I will introduce a port function for printing strings in my next patch soon, please be patient.

@dbatyai dbatyai closed this Dec 8, 2021
@lygstate
Copy link
Contributor Author

lygstate commented Dec 8, 2021

@dbatyai
That's sounds very good, I am looking for it.

@lygstate lygstate deleted the jerry_port_string_print branch November 13, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants