[pull] main from whatwg:main #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Also fixes a nearby typo.
The 'concrete object size ignoring natural dimensions' concept was not implementable. This change makes `sizes=auto` required on `img` to use auto-sizes (still optional on `source`) and forces size containment so that the image size is the same before and after an image has loaded, to prevent double downloads. Fixes #9448, fixes #9648, and fixes #9649.
This accidentally was lost in 0a97a81.
As discovered in whatwg/streams#1298 (comment), Promise<T> is actually not an appropriate type for it.
The pagereveal event is fired at the beginning of the first rendering opportunity after activation (initial load or reactivation). It is a way for the author to execute some JS that affects the presentation "just in time" for the first frame. If there is an inbound cross-document view transition, the reveal event holds a reference to the ViewTransition object. Closes #9315.
The previous prose to make `overflow` act as `visible` with regards to other CSS features but still clip didn't work well with e.g. `text-overflow: ellipsis`. CSS now has a standard way to do what `input` buttons need, i.e. clip and also not affect interaction with `vertical-align`. Fixes #9976.
This is based on this WICG draft: https://wicg.github.io/custom-state-pseudo-class. This has been discussed in these issues (among others): w3ctag/design-reviews#428 & w3c/csswg-drafts#4805. This will be added to Selectors level 5: w3c/csswg-drafts#4805. Tests: https://wpt.fyi/results/custom-elements/state. Co-authored-by: Domenic Denicola <[email protected]>
A few definitions that expect a CanvasImageSource incorrectly omitted the OffscreenCanvas case. A couple of non-normative notes were also missing OffscreenCanvas.
This adds two pieces of advice discussed in w3c/html-aam#509 and #9899. Co-authored-by: Scott O'Hara <[email protected]>
In #9796 I refactored the term "auto directionality" to move the fallback to the parent directionality out of the definition of "auto directionality", since I needed the null result in one case to continue a tree traversal rather than returning. However, I missed fixing up one of the references to the term (should I blame the line break?), leaving a case where the spec could define the directionality of a <bdi> element as null. This fixes that case, and converts the <ol> to a <dl class="switch">. Tests: web-platform-tests/wpt#43896.
See w3ctag/design-principles#448 (comment) for some background.
Previously, the standard used the ill-defined phrase "All messages received by that port must immediately be retargeted at the Worker object." This was not a sufficiently clear processing model. Instead, introduce the "message event target" concept to fire the events on the appropriate EventTarget. This also adds linkable definitions for "inside port" and "outside port", and references them appropriately.
In this situation ``` <button popovertarget=foo>Activate <div popover id=foo>Clicking me shouldn't close me</div> </button> ``` clicking the button properly activates the popover, however, clicking on the popover itself after that should not close the popover. It currently does because the popover click bubbles to the `<button>` and activates the invoker, which toggles the popover closed. This fixes that case.
See w3c/csswg-drafts#5312. And also #5429 for where all of this started. This should help #6731 quite a bit too.
See whatwg/spec-factory#76 for context.
This is the specification that is more likely to be impacted.
As suggested in whatwg/fetch#1783 (comment), this change updates an existing use of blob URL entry's object so that the "obtain a blob object" algorithm is used instead. This algorithm was added in w3c/FileAPI#201.
These pseudo-classes are defined in CSS here: https://drafts.csswg.org/selectors-4/#open-state
Since that's an obsolete element, it's not so helpful to include.
Make iframe elements use post-connection steps, not insertion steps. Fixes #10828.
Closes #10844. Also handles the case of a blob: URL with a null blob URL entry, e.g., window.open('blob:https://video_url').
In "the rules for choosing a navigable," the method to find an existing navigable by name is vague. This updates the definition to accurately reflect what the major implementations do. There are some differences between implementations, so there remains in the spec some optional/implementation-defined behavior, but it's much narrower. In particular, note that lookups are now explicitly scoped to browsing context groups. The previous language in the named lookup about "the user agent determines that the two browsing contexts are related enough" is now no longer a part of the lookup logic, but a consequence of the BCG swap decisions. In "obtain a browsing context to use for a navigation response," the existing spec only mentions COOP enforcement as a reason to do a browsing context group swap. Some implementations perform a swap for additional security and performance reasons. This is now reflected in the spec. For context, see: * #313 * #4198 (comment) * #5350 This closes #313, but we have opened the following issues to track the remaining implementation-defined interop gaps: #6356, #10842, #10848, #10849, #10850. Co-authored-by: Domenic Denicola <[email protected]>
While here we also teach the remaining "enqueue a custom element callback reaction" callers about lists. Corresponding DOM PR: whatwg/dom#1331.
Corresponding DOM PR: whatwg/dom#1334.
The remove steps do not return anything, so we do not need to return null. Additionally, the url attribute of StorageEvent is a USVString, so let's initialize the event with the serialization of URL for clarity.
This makes the argument order consistent and corrects a false statement about what the XML fragment parser returns. It also generally improves alignment with Infra and other best practices, though it does not improve the actual integration with the parsers.
This was missed in #10818.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )