Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add H2 stress tests #12610

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Conversation

lorban
Copy link
Contributor

@lorban lorban commented Dec 4, 2024

Add H2 input and output stress test that uses client aborts and asserts that threads are not left stuck on locks.

Ideally, this test (and probably all other stress tests) should be ran at least once before every release; but probably they should be running nightly, and be excluded of PR builds. @olamy what's the current policy?

…re not left stuck on locks

Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban requested review from olamy, gregw and sbordet December 4, 2024 10:56
@lorban lorban self-assigned this Dec 4, 2024
@wendigo
Copy link

wendigo commented Dec 4, 2024

Thanks, that exactly the issue we've been observing!

@joakime
Copy link
Contributor

joakime commented Dec 4, 2024

Ideally, this test (and probably all other stress tests) should be ran at least once before every release; but probably they should be running nightly, and be excluded of PR builds. @olamy what's the current policy?

Having the main branch builds (not PRs or other branches) run with @Tag("stress") is probably a good idea.
We could easily make the nightly builds run with them.
But I think a weekly build (over a Saturday) is probably a better choice. (to avoid other CI builds from impacting the stress test)

@olamy
Copy link
Member

olamy commented Dec 5, 2024

Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban requested a review from gregw December 9, 2024 11:36
@lorban lorban changed the title Add H2 stress test Add H2 stress tests Dec 9, 2024
@lorban lorban merged commit 5901f71 into jetty-12.0.x Dec 18, 2024
10 checks passed
@lorban lorban deleted the experiment/jetty-12.0.x/h2-reset-stress-test branch December 18, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

6 participants